Forum OpenACS Development: Error in Acs Object Management Form Params

Collapse
1: Error in Acs Object Management Form Params
Posted by Dave Bauer on 06/28/13 03:18 AM
This commit introduced an interesting bug

http://cvs.openacs.org/browse/OpenACS/openacs-4/packages/acs-object-management/tcl/form-procs.xql?r=1.4

where if you have multiple forms for the same object type and object view it will pull ALL the parameter values for every form if you have the same element name/id on multiple forms for the same view.

Ryan, if you see this, any idea what this query is trying to do? I can't wrap my head around some of these subqueries.

Collapse
2: Re: Error in Acs Object Management Form Params (response to 1)
Posted by Dave Bauer on 06/28/13 03:33 AM
Aha.

Its missing a where

and aovawp.object_view = :object_view

otherwise it pulls every parameter for the same atribute regardless of the object_view.

If I can remember my CVS login I'll commit :)

Collapse
3: Re: Error in Acs Object Management Form Params (response to 1)
Posted by Dave Bauer on 07/02/13 02:46 AM
OK, my ssh key works so this fix is committed.
Collapse
4: Re: Error in Acs Object Management Form Params (response to 3)
Posted by Ryan Gallimore on 07/02/13 03:01 PM
Thanks for fixing that, Dave.
Collapse
5: Re: Error in Acs Object Management Form Params (response to 3)
Posted by twan arkink on 07/05/13 10:00 AM
Great work, you've helped me out a lot :)