Forum Release Management: forums (changes between 5.10.0 and 5.10.1)

Changes in the forums package between OpenACS 5.10.0 and 5.10.1

Bug Fixes

• Fix broken message key (74cadd4f)
• Fixes for Oracle compatibility (f5db030e)
• Rely less on values provided by the connection (f85185af)

Reforms

• Adapt template::element calls after replacing template::util::get_opts (16b22e9e)
• Mark service contract implementations as private (bb6e3b3b)
• Use UTF-8 emojis instead of actual images to render supported smileys in forum posts (335f1ede)

Improvements

• Performance Improvements

  • Avoid transaction when unnecessary (aeb4e876)
  • Use cached api when detecting if attachments are supported (83b9a2e8)

• Security Improvements

  • Improve server response in error situations (b2e833ab)
  • Harden page contract validation (c92794b8, 22c992f2, 655eea7b, 619b2580, c403e313, 189442f8, 0a4c5d1d)
  • Increase permission checking (6ddf512d)

• Code Refactoring

  • Pass properties in adp consistently with @....;literal@ best practice (dc2b6f8f, 44d3483e)
  • Replace deprecated template::util::is_true with inline string idiom (88c779b5)
  • Replace handcrafted HTML icons with new adp:icon adp tag (1b6adbcb, 0cf9dfe4)

• Miscellaneous

  • Cleanup and formatting changes (various commits)
  • Increase test suite of functionalities and cover 100% of public api (various commmits)

Deprecations

• forum::new_questions_allowed_p -> Trivial shotrhand to forum::get (5e7c3e01)
• forum::new_questions_allow and forum::new_questions_deny -> Trivial shorthands to forum::edit
• forum::message::get_attachments -> Unused and repleaceable by other API