Forum Release Management: file-storage (changes between 5.10.0 and 5.10.1)

Changes in the file-storage package between OpenACS 5.10.0 and 5.10.1

Bug Fixes

  • Make fs::get_file_package_id more robust to cases where the package_id is not set on the object itself (bbbbf93b)
  • Fixes for Oracle compatibility (9a5b9cf4, 0d4331cb, de75d648)
  • Fix regression when the files list is rendered in "list" format (d0eecbe4)

Reforms

  • Make oacs-dav an optional, uninstallable dependency (c8e3b5f8)
  • Make Service Contract implementation private and use the abstract api instead (81ef9be7, 6eee7dbd, 846b226b, f56b331a)

Improvements

  • Performance Improvements

    • (Postgres only) Improve performances when fetching folder files using recursive permission api (02f64379)
  • Security Improvements

    • Improve server and client-side input validation (various commits)
  • Code Refactoring

    • Reduce divergency between Oracle and Postgres codebase (55e70c4f, 2cf7bbf5)
    • Replace deprecated template::util::tcl_to_sql_list with NaviServer own ns_dbquotelist (8b1a62d0)
    • Replace deprecated twt::user::create and twt::user::delete with their acs::test::user:: counterpart (cbc632d0)
    • Cleanup obsolete error catching (d99eccfb)
    • Replace handcrafted HTML icons with new adp:icon adp tag (602c473d, 651ab668, 53b1248d)
    • Replace ad_tmpnam with ad_opentmpfile and ad_mktmpdir, safer from race conditions (576d51a1, 8a9ac2b9)
  • Miscellaneous

    • Cleanup and formatting (various commits)
    • Improve test suite and cover 100% of public api (various commmits)

Deprecations

  • fs::add_created_version -> behavior specific to this proc was to fs::add_version, largely similar (815cbaae)
  • fs::torrent::get_hashsum -> superseded by NaviServer ns_md command (aaf2751d)
  • fs::item_editable_p, fs::item_editable_info -> Unused, unclear usefulness (86cd3917)
  • fs::get_archive_extension -> trivial wrapper over the parameter api (aa63e153)
  • fs::get_folder_contents -> Not used in the codebase, same result can be achieved with other api (72e444b8)