Forum OpenACS Development: Re: Audit of postgres plpgsql procs...

Collapse
Posted by Don Baccus on
"stable" corresponds to "iscachable" in PG < 7.3, and "iscachable" has been kept for backwards compatibility.  I assume you've just listed those that weren't set "iscachable" ...

Since 5.0 is dropping support for 7.2 we might as well adopt the new terminology.  Also we can just drop bittoint4 etc since these are implemented by casts in 7.3 (these bit functions were defined by PG itself in 7.2).

Should we do this for 5.0?

Collapse
Posted by Jeff Davis on
iscachable = immutable rather than stable (eg acs_objects_get_tree_sortkey is declared iscachable which makes it immutable in the pg_proc table but it's really stable instead).

Yeah, I think we should fix them for 5.0 (some of them anyway) although I think we should write the update script to manipulate pg_proc directly rather than trying to reload all the changed functions.