Forum OpenACS Q&A: cr_write_content ignores UseBackGroundDeliveryP flag

1: cr_write_content ignores UseBackGroundDeliveryP flag

Posted by Dave Manginelli on 03/21/08 04:26 AM

Cr_write_content (in packages/acs-content-repository/tcl/revision-procs.tcl) appears to use the existence of the ad_returnfile_background proc to determine whether to use background delivery. There is a kernel parameter (UseBackGroundDeliveryP) for that purpose but it is apparently ignored.

Ad_returnfile_background is installed as part of xotcl-core.

I added code to my local copy in order to permit disabling of background delivery without the need to remove xotcl-core using [parameter::get_from_package_key -package_key acs-kernel -boolean -parameter UseBackgroundDeliveryP -default 0] to get the value of the parameter.

Is this the best way to go about this?

2: Re: cr_write_content ignores UseBackGroundDeliveryP flag (response to 1)

Posted by Gustaf Neumann on 03/21/08 12:59 PM

Dave, you are right, background delivery does not work with nsopenssl, there is no easy way to address the problem. The best approach is to deactivate it automatically, when a request comes via SSL.

I was not aware about the flag UseBackGroundDeliveryP, and did some history mining. The flag was introduced by Mannheim in 5.2 (as parameter with code in revision_procs), but then the changes were reverted soon after that, but whoever did the revert missed the flag in the kernel parameters.

http://cvs.openacs.org/cvs/openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl?only_with_tag=oacs-5-2

It is better to deactivate background delivery automatically in cases where it is known not to work, than to depend on an admin deactivating it manually.

i have made this fix in cvs head, oacs-5-4 and oacs-5-3.

3: Re: cr_write_content ignores UseBackGroundDeliveryP flag (response to 2)

Posted by Dave Manginelli on 03/21/08 07:01 PM

You're fast Gustaf!

Thanks for the speedy response. I'll grab your fix from CVS.