Forum OpenACS Development: Re: Can't send mail from acs-mail-lite

4: Re: Can't send mail from acs-mail-lite (response to 2)

Posted by Jeff Davis on 07/14/04 09:52 AM

It turns out the rewrite of acs-mail-lite ignored the acs-rollout-support stuff since it dispensed with the ns_sendmail call (acs-rollout-support redefined ns_sendmail to do it's magic). Jade put something back in to do rollout support but when he did he got the extraheaders bit wrong (since it's a list at that point). For ns_sendmail it's always been an ns_set and it's wrong to change it to try to treat it as a list if it's not an ns_set -- look for the comment about Rollout support in acs-mail-lite-procs.tcl in function deliver_mail and you will see where it's broken.

5: Re: Can't send mail from acs-mail-lite (response to 4)

Posted by Steve Manning on 07/14/04 10:31 AM

Ah I see. In deliver_mail before the ns_sendmail line I add

set eh [util_list_to_ns_set $extraheaders]

and then replace $extraheaders with $eh in the ns_sendmail parameters.

Thanks Jeff. Later today I'll add that as a bug and patch if its not already there.

Steve

6: Re: Can't send mail from acs-mail-lite (response to 5)

Posted by Jeff Davis on 07/14/04 11:06 AM

I committed a fix for this to HEAD. It should not happen on 5.1 since on 5.1 the acs-rollout-support stuff is still just ignored in acs-mail-lite. bcc also needs to be fixed but I think in rollout support the bcc is just ignored so maybe it does not matter.

7: Re: Can't send mail from acs-mail-lite (response to 6)

Posted by Steve Manning on 07/14/04 11:32 AM

My version is straight out of the repository two days ago. A quick browse of the cvs shows that version 1.16 of acs-mail-lite-procs.tcl contains the fix but the repository is bringing back v1.15. Does 1.16 need to be tagged as openacs-5.1-compat for the repository to return it?

Steve

8: Re: Can't send mail from acs-mail-lite (response to 7)

Posted by Jeff Davis on 07/14/04 01:38 PM

I don't know why the openacs-5-1-compat tag is on HEAD rather than the 5.1 branch; that seems wrong to me. I moved the openacs-5.1-compat to 1.16 though so you should be able to update to pick up the fix.