Forum .LRN Q&A: Re: navigation changes in dotLRN: RFC

Collapse
Posted by Malte Sussdorff on
I18N: I guess we are talking about something *TOTALLY* different. What I'm saying is, it is bad coding style to mandate a string to be a localized string. You do this. In the parameter you are saying "/pvt/home selva-theme.Home". This is in the parameter and in the tcl procedure you say: [_ name] where name is the second part of the parameter which is "selva-theme.Home". Now comes the occasional user that has heard he can change the number of subnavbars using this parameter. He wants to add "/contacts Contacts". He does not care about I18N, it is a plain english site. You approach will result in "MESSAGE KEY missing: Contacts". This is why you should never take a string and run it through [_ ] unless you are 100% sure it will be a valid message key.

As for relying on other packages, well, fine with me, but keep one thing in mind. You will force translators to translate the *exactly* same string twice, because you are running this on OpenACS 5.1.5. It would be considerably better to take the 5.2 acs-subsite catalog file and store it in 5.1.5.

Blank-Master changes from OpenACS version to OpenACS version, so unless there is a compelling reason not to use it, one should. Probably this is why DS is broken on my 5.2 install.

As for the rest, fine with me and we could start a new thread :).

P.S.: I'm not sure how long .LRN will run on 5.1, but I think it should move to 5.2 within this year, as it already works beautifully on 5.2 and there a considerable enhancements in 5.2 that make development easier.

Collapse
Posted by Jeremy Monnet on
I18N : Ok, I understand you ! Yes, you're right, that's why I thought we should provide an interface for people to add tabs. This mechanism would take care of adding the correct string where it should (in this event, it would be to add a line in the catalog xml file. I agree it may not be the best solution, but that's the best I have for now). My work is not to make the .LRN more beautiful (even if this is part of it) but to make the .LRN attractive to new comers : easy and beautiful. I know Rafael would like this theme (it goes further than just a theme, but this is the codename for now) for the next stable release, which will probably run OACS 5.1. If you can convince the consortium to move on the current 5.2 OACS release, that will be just fine for me 😊

Blank-master : My only problem is that it uses lots of css (4 if I well remember) which will be confusing in the pure theming part ... Do you know who I should talk to, in order to find an agrement to remove the unused css (3 on 4) from this template ?

Jeremy (who will start a new thread tomorrow from the office)