Forum OpenACS Development: Re: In 5.3.0 final, unable to drop content type using content_type__drop_type() in pg-8.1.5

This also led me to look at the code for content_type__drop_type() and I found some inconsistancies:

The api browser revealed there are two versions, one taking 3 parameters and the other taking those three plus one more.

One of the parameters in common to both calls tells whether the aux table associated with the type should be dropped.

The additional parameter in the four-argument version specifies whether the child types of the type in question should be dropped.

There is also a recursive call whose purpose is to drop child types; the four-argument version has this call enclosed in an if statement that checks the parameter.

One thing I found that was inconsistant, is that in the three-argument version, the parameter of whether to drop the aux table is not passed to the recursive call, but it is in the four-argument version.

Another thing I found, was that even though the original (oracle) code shows that the default for the parameter was to not drop the child types, the three-argument version does drop the children.

OK, this is wrong... just forget I wrote this part :)

Actually the extra parameter was whether to drop objects, not child types, and that part works fine. There is no code to drop the objects in the 3-argument version, and that satisfies the default case.