Forum OpenACS Development: bug fixes from 4.6 merged to HEAD

Thanks,
/Bart

The problem is taht I didn't realize when I wrote the script, that you have to explicitly call some notifications:: functions to generate the mail.

Now that I know that, I have to figure out a way to call these functions from a non-OpenACS/AOLserver script. My script can get away with putting things into the forums because forums has a PL/pgSQL API, so I just connect to the database and use that API.

No such PL/pgSQL API exists for notifications, which means that I'll have to write it. That's why it has taken some time.

-Roberto

-Roberto

You have to add a "{" to line 44 in file
"acs-bootstrap-installer/db-init-checks-postgresql.tcl"
} elseif { [string equal $version "7.3"] } {
(the last "{" was missing)

That said, it might be related to having removed workflow from the core (I thought lars had fixed that one though).

I'm getting lots of errors as well all seeming to be related to the acs-lang package and then the same RestrictToSSL error mentioned as well.

Any help would be most appreciated. I'm trying to use OACS for the first time!

Here go the errors I'm getting:

[16/Jan/2003:17:54:44][2065.6151][-conn3-] Notice: Querying '
      select locale, package_key, message_key, message
      from  lang_messages
      where package_key = acs-templating;'
[16/Jan/2003:17:54:44][2065.6151][-conn3-] Error: Ns_PgExec: result status: 7 message: ERROR:  Attribute "acs" not found

[16/Jan/2003:17:54:44][2065.6151][-conn3-] Error: dbinit: error(myhost.mydomain.com:5432:myserver,ERROR:  Attribute "acs" not found
): '
      select locale, package_key, message_key, message
      from  lang_messages
      where package_key = acs-templating
    '
[16/Jan/2003:17:54:44][2065.6151][-conn3-] Debug: <p>Failed to install ACS Templating, version 4.5.  The following error was generated:
<pre><blockquote>
Database operation &quot;select&quot; failed (exception NSDB, &quot;Query was not a statement returning rows.&quot;)

ERROR:  Attribute &quot;acs&quot; not found

SQL:
      select locale, package_key, message_key, message
      from  lang_messages
      where package_key = acs-templating

</blockquote></pre>

And this occurs later several times:

[16/Jan/2003:18:12:14][2065.3076][-conn0-] Debug: NO FULLQUERY FOR dbqd.acs-bootstrap-installer.installer.site-info-2.main_site_id_select --
<blockquote> using default SQL
</blockquote>
[16/Jan/2003:18:12:14][2065.3076][-conn0-] Notice: Querying '
    select package_id from apm_packages
    where instance_name = 'Main Site';'
[16/Jan/2003:18:12:14][2065.3076][-conn0-] Notice: dbinit: sql(myhost.mydomain.com:5432:myserver): '
    select package_id from apm_packages
    where instance_name = 'Main Site'
'
[16/Jan/2003:18:12:14][2065.3076][-conn0-] Notice: Querying '
            select apm__set_value(
                '641',
                'RestrictToSSL',
                'acs-admin/*'
            );'
[16/Jan/2003:18:12:14][2065.3076][-conn0-] Error: Ns_PgExec: result status: 7 message: ERROR:  -20000: The specified package 641 AND/OR parameter RestrictToSSL do not exist in the system

[16/Jan/2003:18:12:14][2065.3076][-conn0-] Error: dbinit: error(myhost.mydomain.com:5432:myserver,ERROR:  -20000: The specified package 641 AND/OR parameter RestrictToSSL do not exist in the system
): '
            select apm__set_value(
                '641',
                'RestrictToSSL',
                'acs-admin/*'
            );
        '
[16/Jan/2003:18:12:14][2065.3076][-conn0-] Error: Error sourcing /www/nsroot/myserver/packages/acs-bootstrap-installer/installer/site-info-2.tcl:
Database operation "0or1row" failed (exception NSDB, "Query was not a statement returning rows.")

ERROR:  -20000: The specified package 641 AND/OR parameter RestrictToSSL do not exist in the system

SQL:
            select apm__set_value(
                '641',
                'RestrictToSSL',
                'acs-admin/*'
            );

    while executing
"ns_pg_bind 0or1row nsdb0 {
            select apm__set_value(
                :package_id,
                :parameter,
                :value
        ..."
    ("uplevel" body line 1)
    invoked from within
"uplevel $ulevel [list ns_pg_bind $type $db $sql"
    invoked from within
"db_exec 0or1row $db $full_statement_name $sql"
    invoked from within
"if {[regexp -nocase -- {^\s*select} $test_sql match]} {
            db_qd_log QDDebug "PLPGSQL: bypassed anon function"
            set selection [db_..."
    ("uplevel" body line 6)
    invoked from within
"uplevel 1 $code_block "
    invoked from within
"db_with_handle db {
        # plsql calls that are simple selects bypass the plpgsql
        # mechanism for creating anonymous functions (OpenACS - ..."
    (procedure "db_exec_plsql" line 13)
    invoked from within
"db_exec_plsql set_parameter_value {}"
    (procedure "parameter::set_value" line 7)
    invoked from within
"parameter::set_value -package_id $package_id -parameter $name -value $set"
    (procedure "ad_parameter" line 4)
    invoked from within
"ad_parameter -set "acs-admin/*" -package_id $main_site_id RestrictToSSL"
    (file "/www/nsroot/myserver/packages/acs-bootstrap-installer/installer/site-info-2.tcl" line 45)
    invoked from within
"source $__file "

And this as well:

[16/Jan/2003:17:54:43][2065.2051][-sched-] Notice: Running scheduled proc lang::catalog::import_from_all_files_and_cache...
[16/Jan/2003:17:54:43][2065.2051][-sched-] Error: invalid command name "lang::catalog::import_from_all_files_and_cache"
invalid command name "lang::catalog::import_from_all_files_and_cache"
    while executing
"lang::catalog::import_from_all_files_and_cache"
    ("eval" body line 1)
    invoked from within
"eval [concat [list $proc] $args]"
    (procedure "ad_run_scheduled_proc" line 43)
    invoked from within
"ad_run_scheduled_proc {f t 5 lang::catalog::import_from_all_files_and_cache {} 1042768478 0 t}"

Thanks for any help. This is my first attempt to play with OACS and we hope to use it for a production site!

A recent cvs checkout from -HEAD (just a couple of hours old) throws a whole bunch of errors when installing just about everything.

I've tried upgrading Pg driver to nspostgres-3.5, but it gets recognised as an outdated, with a suggestion to update...

This is with the released 4.6, not with HEAD.  I can try a HEAD install, though.....but only with PostgreSQL 7.2.3.

Did you recompile nspostgres for PostgreSQL 7.3.1? (it should have had other complaints for that error, but it doesn't hurt to ask).

Also, check to make sure the run user for AOLserver has the proper access rights to all tcl files -- improper ownership and modes in the aolserver install directories can cause symptoms similar to this.  That is, if AOLserver is being run as 'nsadmin' then nsadmin should probably own the entire aolserver install tree.  In particular, AOLSERVER_HOME/modules/tcl should be owned by nsadmin. Or grant read and execute to the whole tree (execute to the directories only, IIRC).

This error should have caused an immediate error, though, not just in the fourth page.

Which AOLserver version are you using?

Like I said, this is with Pg7.2.3.  Will try upgrading to 7.3.1 and see if that helps.

My feedback to this thread has not been a "please help it does not work" -- I simply find it interesting that what used to work a dozen times I've installed and configured is not working now.  I am trying to see what causes these breakages and how they can be mitigated, whether it is a praticular combination of OS/db/AOLserver.  Unlike many here, for instance, I prefer to use FreeBSD, not Linux, even though this calls for a bumpier ride -- yet there's no reason while it should not work, is there?

Fair enough. FWIW, if anybody is having the "You need to update" error -- make sure that you compile nspostgres with ACS=1 as follows:

  $ gmake ACS=1 POSTGRES=/usr/local
...
  $ gmake ACS=1 POSTGRES=/usr/local install

(substitute for just make on Linux).

As far as nssha1 is concerned -- lines 139 and 140 of nssha1.c need to be commented out if you are compiling in FreeBSD (probably it should just be wrapped in to a sensible #ifdef/#endif:

--- nssha1-0.1/nssha1.c.org     Mon Jan 20 00:57:45 2003
+++ nssha1-0.1/nssha1.c Mon Jan 20 00:52:46 2003
@@ -136,8 +136,8 @@
     return NS_OK;
 }

-typedef unsigned int u_int32_t;
-typedef unsigned char u_int8_t;
+/*typedef unsigned int u_int32_t;
+typedef unsigned char u_int8_t;*/

 /*** FROM sha.h: ***/

After these changes all is good with the follwoing setup: FreeBSD 5.0-CURRENT/postgresql-devel (7.3.1) from ports/OpenACS 4.6-final

Just a note to let everyone know that I got to the final install page of the OACS today. I had only a couple errors in the process. Not sure yet how badly they affect the use of OACS since I'm going to lunch before playing any further. I'm happy about the install now and don't want to bum myself out before lunch!

Anyway, I have the cvs head of the 4.6 branch ( I think! I checked it out with "cvs -z3 -d :pserver:mailto:anonymous@openacs.org/cvsroot co openacs4" this morning (Jan 20).
I'm running postgres 7.3.1 on redhat linux 7.3 (with a later kernel).

The 2 errors I saw in my error log (didn't show up on any of the OACS install screens) were:

This one during the install screens somewhere:
[20/Jan/2003:11:54:51][22490.2051][-sched-] Notice: Running scheduled proc
search_indexer...
[20/Jan/2003:11:54:51][22490.2051][-sched-] Error: invalid command name
"search_indexer"
invalid command name "search_indexer"
    while executing
"search_indexer"
    ("eval" body line 1)
    invoked from within
"eval [concat [list $proc] $args]"
    (procedure "ad_run_scheduled_proc" line 43)
    invoked from within
"ad_run_scheduled_proc {f f 60 search_indexer {} 1043092011 0 t}"

This one after I restarted the server:
[20/Jan/2003:11:58:26][22552.2051][-sched-] Error:
lang::catalog::import_from_files - The import of file
/www/nsroot/myhost/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
failed, error message is:

invalid command name "ns_charsets"

stack trace:

invalid command name "ns_charsets"
    while executing
"ns_charsets"
    (procedure "default_charset_if_unsupported" line 2)
    invoked from within
"default_charset_if_unsupported $msg_encoding"
    (procedure "read_file" line 7)
    invoked from within
"read_file $file_path"
    (procedure "import_messages_from_file" line 6)
    invoked from within
"import_messages_from_file $file_path"

This last error occurred for multiple language packages.

Thanks for all the help:)
        t

> Andrei: Regarding the ACS=1 information.  That is correct;
> I had not thought of the fact that OpenACS would say
> 'you need to update' instead of 'your PostgreSQL driver
> doesn't contain the extra functionality required by
> OpenACS'.

--- packages/acs-bootstrap-installer/db-init-checks-postgresql.tcl.org  2003-01-22 12:11:48.000000000 +0100
+++ packages/acs-bootstrap-installer/db-init-checks-postgresql.tcl      2003-01-22 12:08:56.000000000 +0100
@@ -41,7 +41,7 @@
     }

     if { [catch { ns_pg_bind 1row $db "select count(*) from pg_class" }] } {
-        append my_errors "<li>Your Postgres driver is too old.  You need to update\."
+        append my_errors "<li>Your PostgreSQL driver was not compiled with OpenACS support.  Please recompile it with <tt>ACS=1</tt>.\n"
         set my_error_p 1
     }