Hi

I've downloaded the Jabber package from the contribs section to evaluate it but I'm having a problem compiling the nsjabber module. When I run 'make' I hit a problem with the first compile which seems to be related to the jabber.h include. The output is about 14k but starts like this:

gcc -I../include/xode  -I../../include -I../include/jabber -I../include -I../../nsd  -I../../include -D_REENTRANT=1 -DNDEBUG=1 -g -fPIC -Wall -Wno-unused -mcpu=i586 -DHAVE_CMMSG=1 -DUSE_FIONREAD=1 -DHAVE_COND_EINTR=1  -c -o jpacket.o jpacket.c
In file included from jpacket.c:20:
../include/jabber/jabber.h:59: parse error before "pool"
../include/jabber/jabber.h:59: warning: no semicolon at end of struct or union
../include/jabber/jabber.h:65: parse error before '}' token
../include/jabber/jabber.h:65: warning: type defaults to `int' in declaration of `jid'
../include/jabber/jabber.h:65: warning: data definition has no type or storage class
../include/jabber/jabber.h:67: parse error before "jid_new"
../include/jabber/jabber.h:67: parse error before "p"
../include/jabber/jabber.h:67: warning: type defaults to `int' in declaration of `jid_new'
../include/jabber/jabber.h:67: warning: data definition has no type or storage class
../include/jabber/jabber.h:68: parse error before "id"
../include/jabber/jabber.h:69: parse error before "id"
../include/jabber/jabber.h:70: parse error before "a"
../include/jabber/jabber.h:71: parse error before "a"
../include/jabber/jabber.h:72: parse error before "jid_append"
../include/jabber/jabber.h:72: parse error before "a"
../include/jabber/jabber.h:72: warning: type defaults to `int' in declaration of `jid_append'
../include/jabber/jabber.h:72: warning: data definition has no type or storage class
../include/jabber/jabber.h:73: parse error before "jid_xres"
../include/jabber/jabber.h:73: parse error before "id"
../include/jabber/jabber.h:73: warning: type defaults to `int' in declaration of `jid_xres'
../include/jabber/jabber.h:73: warning: data definition has no type or storage class
../include/jabber/jabber.h:74: parse error before "jid_nodescan"
../include/jabber/jabber.h:74: parse error before "id"
../include/jabber/jabber.h:74: warning: type defaults to `int' in declaration of `jid_nodescan'
../include/jabber/jabber.h:74: warning: data definition has no type or storage class
.
.
.

There's plenty more of that if its required. I'm using gmake version 3.79.1 on Linux. My C skills aren't up to this so any assistance would be appreciated.

Thanks

    Steve

Thanks but sorry you've lost me there. Do you mean in jpacket.c or in jabber.h? Do you mean ctrl-z cos I can't find any?

  Steve

Thanks Andrew

Before I posted I'd already looked around the jabber.h source file at line 59 because I was thinking the same thing. I've looked at a hex dump of the file and I can't see anything other than ASCII 0x20 for the spacing and 0x0A for the line feeds.There is nothing hiding that I can see. The area around line 59 looks like this with line 59 being the  pool p; line:


#define JID_RESOURCE 1
#define JID_USER    2
#define JID_SERVER  4

typedef struct jid_struct {
    pool              p;
    char*              resource;
    char*              user;
    char*              server;
    char*              full;
    struct jid_struct *next; /* for lists of jids */
} *jid;

jid    jid_new(pool p, char *idstr);          /* Creates a jabber id from the idstr */


I'm wondering if there is something hiding above this in the file and this is causing the compiler to barf at line 59.

The file is striaght out of the OACS contribs on the CVS. Prior to getting this problem I did nothing more than untar it, copy into my AOLServer dir and run the make - its weird. Has anyone succesffully compiled this package previously?

Yes I had problems early on with a missing include dir that turns out to be in the ns-jabber-patch tarball which I'd originally missed. Your compile failed because libxode needs to be present. As you say its a mess but I can't attribute anything in there to my problem. I ran Dos2Unix over the files and it didn't find anything to change so I don't think its a DOS file problem. I'll try an email to the maintainers directly.

Thanks for trying.

    Steve

Hi Tom

Yes I did. It turned out that the version on the cvs won't compile but if you get the version from file storage it works. These are the links provided by Bjoern Kiesbye:

http://openacs.org/storage/index?folder_id=70462&n_past_days=99999
(information)

http://openacs.org/storage/download/jabber-0.3a.apm?version_id=93092
(complet)

http://openacs.org/storage/download/nsjabber-patch-1.tar.gz?version_id=97881
(patch)

By the way there is a caveat that it probably won't compile under aols4 - don't know if thats been resolved.

    - Steve

Hi,

I have uploaded the nsjabber-0.1.0.2.tar.gz to the file storage, this version works with Aolserver 4 (only).
You are able to compile the old version with Aolserver 3 after editing the Makefile but the conferencing System will not work, due to a change in Aolservers ns_set c-api.
As well it includes all changes (speed enhancement) and Bugfixes, since the last release.

You can find it here:
http://openacs.org/storage/file?file_id=187244

Bjoern, there was a bug in file-storage upload (under aolserver 4 and another thing that has been fixed since 4.6.3) which corrupted binary files. I fixed it so if you could upload your file again that would be great.

I've had a (casual) look through the code for this. In terms of the OpenACS part of the package, porting to PostgreSQL would be as easy as for any other package, i.e. a little tedious but not hard. Oracle to PostgreSQL is generally easier than the other direction, IMO.

What could be tricky is removing database-dependence from queries in the C code. Generally, access is done via PL/SQL accessors, however PL/SQL blocks in Oracle are different to those in PostgreSQL (at least from within OpenACS, PostgreSQL db_exec_plsql blocks are really functions that get executed with a select statement, and so have to have a return value), so this would raise an issue. Making it run on PostgreSQL _instead_ of Oracle would be comparatively easy, database independence would be hard (but maybe a fun problem to crack ).

If I decide to go ahead with using this package for my current project, I think it quite likely that I'd need to port to PostgreSQL, so I'll try and keep the community informed to avoid duplication of effort.

Hi,

I have uplaoded the file again hope it will work this time.You find it here:

http://openacs.org/storage/file?file_id=187244

As well I have uploaded a tarball that includes a Jabber package and a nsjabber module which both support postgres.
It's in early testing state, so if you like you can test it.

You find them here:
http://openacs.org/storage/file?file_id=187511

I ran into the problem with the db_exec_plsql Tom mentioned above, changing them to db_dml statements which execute a begin ... end; Block would work for oracle, but  postgres wont execute a Select statement inside a dml call.
And I dont think it's posible to execute pgpsql code directly you always have to compile a function first and then trigger it by calling it with a Select statement.

An aproach would be to change all plsql procedures to functions (oracle) which return dummy values, so they can be called inside Select statements as well (select func1 from dual).Does any one knowe how much more time a db_select would take compared to a db_exec_plsql?

Why don't you just put a check in the C code to change the SQL for each DB?

I added the extern char * DB_DRIVER, then in tcl_jclient.c:

DB_DRIVER = strdup ( ((cache  = Ns_ConfigGetValue("ns/db/pool/jabber" , "driver"))?cache:"postgres") );

Then, where SQL is used:
if (strcmp(DB_DRIVER,"postgres") == 0) {
    snprintf(query, 4096, "select jb_update_status ('%s' , %s' , '%s' , '%s');", state, jb->resrc, jb->jid , jb->service);
  }
  else {
    snprintf(query, 4096, "begin jb_update_status ('%s' , %s' , '%s' , '%s');  end;", state, jb->resrc, jb->jid , jb->service);
  }

Works for me. . .

Of course, this is all stuff I did because when I first started looking at it I couldn't find any references to the jabber package even being actively developed. . .

** Martin

Hi,

the problem isn't nsjabber, during header runs (compilation) I can not just define which SQL should be used (like openacs does it with .xql files) as well I can define which db_api call should be used (dml for oracle, Select for postgres). Even if nsjabber with postgress support doesn't run Bug free jet (because I changed some other things together with the  postgres port (db access)).

This problem  ocures in oacs only, do we have a flag which determines which db an oacs installation is using ?
I could then wrap the db calls into if statemnts (their are only a few which are not called often (only when a screen/conference_room object is droped)).

I've fixed some bugs in the jabber-create.sql , you can grap it here.

http://openacs.org/storage/download/index?version_id=188373

Hi Martin did you already wrote a jabber-drop.sql? If so could you upload it to the file storage, I will include it into the package then.

Hi Martin,

Your Idee isn't bad , but we would have to do a second check when the sql is actualy executed , for oracle I use Ns_DbDML and for Postgres Ns_DbExec this is neseccary for at least some of the queries. As well the first check had to be doen everywhere in the code where a SQL query is created (the extra time loss wouldn't be the big problem but it would blow up the code and makes it less readable).

I #define CONSTANS for each query during precompiler run, they are defined whith  SQL querys for oracle or postgress (db_jclient.h), the CONSTANTS are then replaced (in the second recursive precompiler run) inside the code with the previously defined SQL queries.


db_jclient.h looks like that:

#if JBDB == ORA

//first how to execute dml satements
#define JBDB_EXEC_DML ret =  Ns_DbDML(handle, sql);

// the sql  from db_jclient.c
#define JBDB_UPDATE_STATUS  "begin jb_update_status
('%s' , '%s' , '%s' , '%s');  end;"

//sql from lib_jclient.c
#define JBDB_MESSAGE_LOG "update jb_message_log set conn_state='0' ,
send = sysdate where message = '%s' and screen = '%s'"

#elif JBDB == POSTGRES

//first how to execute dml satements
#define JBDB_EXEC_DML(handle , sql) ret = Ns_DbExec(handle , sql);

//the sql  from db_jclient.c
#define JBDB_UPDATE_STATUS  "Select jb_update_status ('s' , '%s' , '%s' , '%s')"

//sql from lib_jclient.c
#define JBDB_MESSAGE_LOG "update jb_message_log set conn_state='0' ,send = curent_timestamp where message = '%s' and screen = '%s')"


Inside the *.c files it looks like this then (no extra if blocks are nesecary):

snprintf(sql , 761 , JBDB_MESSAGE_LOG  , Ns_SetGet(row , "message") , jid_full(id) );
db =  JABBER_Dbml_Main(sql);



This way it's a very littel faster and the code is better readable, the disadvantage is that you need to compile  one nsjabber.so for oracle and one for postgres.

If you want to run both (ora/post) oacs instalations with one Aolserver installation,( I think this will only happen on development Systems)
just compile one nsjabber.so for oracle and one for postgres , create two sub dirs in
/usr/local/aolserver/bin/, name them 'nsjabber-ora' and
'nsjabber-post' and copy the appropriate nsjabber.so files to this dirs. Then change the modul load section of your aolserver-config.tcl that it looks like this:

ns_section ns/server/${server}/modules
ns_param  nssock            ${bindir}/nssock.so
ns_param  nslog              ${bindir}/nslog.so
ns_param  nsdb              ${bindir}/nsdb.so

if { $database == "oracle" } {
ns_param  ns_jabber              ${bindir}/nsjabber-ora/nsjabber.so
} else {
ns_param  ns_jabber              ${bindir}/nsjabber-post/nsjabber.so
}

This way always the appropriate nsjabber.so will be loaded.



To which email address did you send the jabber-drop.sql file (bjoern_kiesbye@web.de)? I did't get any, could you try to send it again.

Thanks

take a look at this thread: http://openacs.org/forums/message-view?message_id=189152