Forum OpenACS Development: Re: OpenACS 5.9 Bug in /admin/group-types/

Collapse
Posted by Gustaf Neumann on
I've created group "Test" (group-type "Group") on the actual version of acs-admin (5.9.1b3) without problems. Notice, that there were several changes to the - still not very good - acs-admin interface for creating/viewing groups [1]; maybe the fix [2] from june 2016 helps? this fix was after the release of 5.9.0.

-g

[1] http://cvs.openacs.org/changelog/OpenACS/openacs-4/packages/acs-subsite/www/admin?max=30&view=all
[2] http://cvs.openacs.org/browse/OpenACS/openacs-4/packages/acs-subsite/www/admin/groups/new.tcl?r1=1.10.2.4&r2=1.10.2.5

Collapse
Posted by Frank Bergmann on
Hi Gustaf,

Just updating acs-subsite/www/admin/groups and group-types didn't change anything.

After exchanging all acs-* packages with packages from your 5.9.1.b3 I get: "invalid command name "ns_parseurl".
I'm already running NaviServer 4.99.8.

I've seen that the diff of acs-subsite from 5.9.0 is already > 3.000 lines. I don't have a good feeling with this. I believe I already announced that we are going to be very conservatives with OpenACS and nsd upgrades in ]po[ from now on. So I assume we'll re-implement group administration in ]po[ now and ignore OpenACS.

Thanks anyway,
Frank

invalid command name "ns_parseurl"
    while executing
"ns_parseurl $location"
    (procedure "util::split_location" line 4)
    invoked from within
"util::split_location [ns_conn location] proto hostname port"
    (procedure "util_current_location" line 24)
    invoked from within
"util_current_location"
    (procedure "::nsf::procs::util::request_info" line 7)
    invoked from within
"util::request_info -with_headers=$with_headers"
    (procedure "ad_log" line 3)
    invoked from within
"ad_log Error "Error in include template \"[template::util::url_to_file "${login_template}" "$__adp_stub"]\": $errmsg""
    ("uplevel" body line 23)
    invoked from within
"uplevel {
Collapse
Posted by Gustaf Neumann on
cherry-picking changes is not a good idea - i was just hoping that this error fixes the 5.9.0 issue. .... however - it looks to me as of there is no issue with the code you are sketching: i have just installed a fresh version of OpenACS 5.9.0, and the issue DOES NOT show up the group "Test" can be created without problems!

-gn

btw: not sure, how you messed to upgrade: If one does a proper upgrade of acs-core, there won't be a problem with ns_parseurl since there is an emulation of it for AOLserver in the code [1].

[1] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-tcl/tcl/utilities-procs.tcl#L5018

Collapse
Posted by Frank Bergmann on
Hi!

5.9.0

Thanks a lot!!

upgrade

I did this upgrade on Linux, and it was NaviServer... Also on Windows it's NaviServer now - I need to keep both versions as close as possible...

But what do you think about a "LTS" long-term support version of OpenACS? Do you think that's feasible?

Cheers,
Frank