Forum OpenACS Development: Error on upgrade to 5.3.2

Collapse
Posted by Jon Griffin on
I am recieving the following error after upgrading 2 sites to 5.3.2.

"elements(sec_fieldset)": no such element in array
while executing
"lang::util::localize $elements(sec_fieldset)"
("for" body line 6)
invoked from within
"for { set __d17_i 1 } { $__d17_i <= ${elements:rowcount} } { incr
__d17_i } {
upvar 0 elements:$__d17_i elements

I tried to use both the compat templates (restarts server every page load), and the new templates, other errors like:
charset=[ad_conn charset] throws an ns_conn error about charset, and still doesn't fix the problem.

This is a killer problem as I can't access admin. At least using my original custom templates works for my user pages.

Collapse
Posted by Malte Sussdorff on
http://openacs.de/xowiki/dotlrn-zen-standards describes the changes and http://openacs.de/xowiki/Web_Forms shows you how you need to transform your sections in ad_form which is causing the error you experience.
Collapse
Posted by Jon Griffin on
BTW, these are standard admin pages from OACS. I can't imagine why these problems happen in a stock upgrade.
Collapse
Posted by Jon Griffin on
Yet again another change to dotlrn messing with non-dotlrn code.
This is getting to be a broken record.
Collapse
Posted by Dave Bauer on
Jon,

Which pages give you this error?

Seems like its only should show up in forms that use sections, if I am not mistaken.

This isn't only for dotlrn of course. Having standard compliant accessbile HTML is a goal for the entire toolkit.

Collapse
Posted by Jon Griffin on
OK, solved.
It appears that on upgrade, acs-subsite is not marked correctly.

Both sites were upgraded from repository and acs-subsite was not updated although all the packages seem to be upgraded.

Collapse
Posted by Jon Griffin on
shared/parameters?package%5fid=461&return%5furl=%2fadmin%2fsite%2dmap%2f

as you can see it is a plain old admin page.

Collapse
Posted by Jon Griffin on
I don't think it has to do with forms. That page doesn't use forms.

I am looking into it, but it does this on 2 sites.

Collapse
Posted by Dave Bauer on
Jon,

Can you explain what not marked correctly means?

It looks like the files in CVS are ok.

Collapse
Posted by Dave Bauer on
I checked here also
https://openacs.org/repository/5-3/
and it says 5.3.2 is available for acs-subsite from the repository.
Collapse
Posted by Jon Griffin on
Well for some reason on these 2 sites, after upgrading from the repository, the actual files for acs-subsite were not created and the old dir not named .bak.

I hope that makes sense. It may have been something on my end but 2 sites out of 4 would be a strange thing.

Collapse
Posted by Dave Bauer on
Jon,

I haven't used the upgrade from repository code, and with such a small user community, its hard to get every bit of the code tested for every release, so I suspect somewhere something is broken.

Thanks for the information, hopefully the problem be can tracked down.

Collapse
Posted by Don Baccus on
I know for a fact that upgrade from the repository was tested (actually it's more common to have upgrade from the tarball not tested).

Yet again another change to dotlrn messing with non-dotlrn code.
This is getting to be a broken record.

We've been doing our best to put an end to this, but as Dave mentions above, while changes to make HTML generated by the toolkit validate, and also meet accessibility standards, were driven in the short-term by the needs of the .LRN community, it's something that needs doing for the toolkit at large.

In particular, the accessibility standards will have the force of law in the EU before long, and here in the US there are ADA implications, too. So it's important.

And certainly no one's going to argue that generated valid HTML is a bad thing, right?

And I might add that moving more and more look-and-feel stuff to CSS, to make customization easier, has been a goal now for some years. We've put it off over and over again because we've known there'd be short-term pain once we start taking big steps in that direction. Finally we've decided to bite the bullet and move forward. We're trying to make it as easy as possible.

Collapse
Posted by Jon Griffin on
Well there actually was a possible tagging bug, but that isn't important. I believe DaveB fixed it.

As for theme-zen, I don't have an issue with it except that it was for dot-lrn and not really released with OACS compatibility at this point.

I certainly want easier theming (wordpress, and most of the other LAMP projects kick our asses in this regard). It just seems that zen could have been incorporated in the core just as easily as dot-lrn only. After all, dot-lrn is built on top of OACS.