Forum OpenACS Development: Re: File Storage: View vs. Download

Collapse
9: Re: File Storage: View vs. Download (response to 1)
Posted by Dave Bauer on 03/07/08 03:13 PM
Malte,

Here is what I propose.

Make revision_id a URL variable.

So the url would be
file/12345/filename.ext?revision_id=2345

This is because it only makes sense to use revision_id if very limited circumstances so having the url variable should not be a problem if you set the content disposition header.

I do not agree with duplicating the code in cr_write_content in file.vuh either.

I agree this requires a little more thought and design. give me a couple of days to look into this further.

Collapse
10: Re: File Storage: View vs. Download (response to 9)
Posted by Malte Sussdorff on 03/07/08 03:26 PM
I realized that I guess I don't need the revision_id after all. Because everywhere I changed the code to redirect to /file, they were calling cr_write_content with the revision_id *after* figuring out the live revision, which is something file.vuh will do anyway, so we are save there. But when I do this, how could I add a URL variable to a .vuh? Just like any normal one ?