Forum OpenACS Development: Re: AjaxFS turns 1.0 Beta

Collapse
4: Re: AjaxFS turns 1.0 Beta (response to 1)
Posted by Christian Fuchs on
Very nice work. I experience one problem on Mac with Safari or Firefox.
When I click "Add File" it will open the windows, upload fine, then I click Hide.
When I click again on "Add File" it wouldn't do anything.
I tried this on your demosite http://solutiongrove.info/coa/files/#

Maybe this helps.

Collapse
5: Re: AjaxFS turns 1.0 Beta (response to 4)
Posted by Hamilton Chua on
Hi Christian,

Thanks for trying it out and letting me know of the problem. It was a result of a recent update I made which corrected a minor bug.

I have fixed it. updated the demo and committed the change to cvs head.

Best,

Hamilton

Collapse
6: Re: AjaxFS turns 1.0 Beta (response to 5)
Posted by Christian Fuchs on
Thanks, another question:

1. Why are the dialogues "Add file" and "Add URL" still in English even tough the menu items are localized now? Do we need to localize the ajax helper, too?

2. In the folder tree on the left side there are + icons even tough there are no subfolder in the tree.

thank you for your answer and time

Collapse
7: Re: AjaxFS turns 1.0 Beta (response to 6)
Posted by Hamilton Chua on
Hello Christian,

My responses below ....

1. Why are the dialogues "Add file" and "Add URL" still in English even tough the menu items are localized now? Do we need to localize the ajax helper, too?

I'm guessing that you are referring to the text in the toolbar.

AjaxFs already is "internationalized" meaning it uses acs-lang and the text should change if you change the locale. You will, of course, need to create equivalent message keys for the language of your choice. Only English is available right now.

Both Add File and Create URL, use message keys from File Storage.

uploadfile:"Add File",
createurl:"Create a URL",

2. In the folder tree on the left side there are + icons even though there are no subfolder in the tree.

Right now, the code doesn't check at all if the folder has any children so the javasript presumes that all nodes may have children.

I can look into this and see if it's possible to make the nodes smarter so that [+] does not appear if the node has no children.

thank you for your answer and time

You are most welcome, thank you for posting feedback and trying the package out.

Best,

Hamilton