Forum .LRN Q&A: Re: Upcoming change in privacy/guest handling

Collapse
Posted by Andrew Grumet on
Changes have been committed on the dotlrn-2-0 branch.  Files affected are in these packages: dotlrn, dotlrn-portlet, forums-portlet.  The packages were tagged with "pre-privacy-update" prior to committing.

The development was done against oracle.  Queries were ported to postgresql but have not been as carefully tested.

Also, there is one dependence outside of .LRN that should be resolved ASAP.  It concerns user imports in the acs-authentication module.  I haven't committed the change because it falls under OpenACS which is governed by a separate process.

The following patch should be applied to packages/acs-authentication/tcl/sync-procs.tcl:

RCS file: /cvsroot/openacs-4/packages/acs-authentication/tcl/sync-procs.tcl,v
retrieving revision 1.31
diff -u -r1.31 sync-procs.tcl
--- packages/acs-authentication/tcl/sync-procs.tcl  31 Oct 2003 10:29:19 -0000 1.31
+++ packages/acs-authentication/tcl/sync-procs.tcl  21 Feb 2004 02:38:02 -0000
@@ -415,9 +415,8 @@
                                    -can_browse=$can_browse_p \
                                    -user_id $user_id

-                                acs_privacy::set_user_read_private_data \
+                                dotlrn_privacy::set_user_is_non_guest \
                                    -user_id $user_id \
-                                    -object_id [dotlrn::get_package_id] \
                                    -value $read_private_data_p

                            }

Note that this patch adds .LRN-specific code into a non-dotlrn file.  However, the file already has dotlrn-specific code in the form of a call to dotlrn::user_add.  This is probably an area that needs cleaning up but we won't address it here.