Forum OpenACS Q&A: Re: PG 7.2->7.3 upgrade gotcha?

Collapse
28: Re: PG 7.2->7.3 upgrade gotcha? (response to 1)
Posted by Richard Hamilton on 03/22/04 02:25 PM
I am trying to upgrade a 4.6.3 instance at the moment and ran the script to do the functions.

Thank you Jun and Tilmann for doing that - now I know why I really must learn perl!

When I restore the data it was obvious that none of the views had been created and that most of these views were not truncated ones (but depended on cr_xxxx views which were). To make sure that I found them all I modified your script to do views and discovered that the regexp that you have in it is in the default greedy form - which does matter if searching for views.

So here is one possible alternative non greedy regexp for the record :

/^CREATE VIEW "([^"]*)"/

Maybe this will help someone to find other truncated views in some of the more infrequently used packages.

Richard

Collapse
29: Re: PG 7.2->7.3 upgrade gotcha? (response to 28)
Posted by Tilmann Singer on 03/22/04 02:44 PM
Jun wrote the script, not me.

Do you think your change is safe for general use, if yes could you please commit it (if you have commit rights) or provide a patch?