Forum OpenACS Q&A: Ecommerce Shopping Cart Change Quantities

I am having multiple problems with the shopping-cart-change-quantities.tcl page. I can increase quantities from the shopping cart, but decreasing causes this error:

[17/Feb/2001:13:21:37][16947.965637][-conn23-] Error: Ns_PgExec: result status:
 7 message: ERROR:  parser: parse error at or near ")"

[17/Feb/2001:13:21:37][16947.965637][-conn23-] Error: dbinit: error(localhost::
nh,ERROR:  parser: parse error at or near ")"
): 'select max(item_id) from ec_items where product_id=1 and color_choice is nu
ll and size_choice is null and style_choice is null and order_id=27 and item_id
 not in ()'
[17/Feb/2001:13:21:37][16947.965637][-conn23-] Error: Database operation "1row"
 failed (exception NSDB, "Query was not a statement returning rows.")
Database operation "1row" failed (exception NSDB, "Query was not a statement re
turning rows.")
    while executing
"ns_db 1row $db [db_sql_prep $sql"
    (procedure "database_to_tcl_string" line 6)
    invoked from within
"database_to_tcl_string $db "select max(item_id) from ec_items where product_id
=$product_id and color_choice [ec_decode $color_choice "" "is null" "= '..."
    ("foreach" body line 62)
    invoked from within
"foreach product_color_size_style $product_color_size_style_list {
    # quantity_to_add might be negative
    # also there are two special cases that ..."
    (file "/web/nh/www/ecommerce/shopping-cart-quantities-change.tcl" line 76)
    invoked from within
"source $script"
    (procedure "ns_sourceproc" line 6)
    invoked from within
"ns_sourceproc cns92 {}"

When setting a quantity to zero I get this error:

[17/Feb/2001:13:25:24][16947.968709][-conn26-] Error: Ns_PgExec: result status:
 7 message: ERROR:  parser: parse error at or near ")"

[17/Feb/2001:13:25:24][16947.968709][-conn26-] Error: dbinit: error(localhost::
nh,ERROR:  parser: parse error at or near ")"
): 'select max(item_id) from ec_items where product_id=1 and color_choice is nu
ll and size_choice is null and style_choice is null and order_id=27 and item_id
 not in ()'
[17/Feb/2001:13:25:24][16947.968709][-conn26-] Error: Database operation "1row"
 failed (exception NSDB, "Query was not a statement returning rows.")
Database operation "1row" failed (exception NSDB, "Query was not a statement returning rows.")
    while executing
"ns_db 1row $db [db_sql_prep $sql"
    (procedure "database_to_tcl_string" line 6)
    invoked from within
"database_to_tcl_string $db "select max(item_id) from ec_items where product_id
=$product_id and color_choice [ec_decode $color_choice "" "is null" "= '..."
    ("foreach" body line 62)
    invoked from within
"foreach product_color_size_style $product_color_size_style_list {
    # quantity_to_add might be negative
    # also there are two special cases that ..."
    (file "/web/nh/www/ecommerce/shopping-cart-quantities-change.tcl" line 76)
    invoked from within
"source $script"
    (procedure "ns_sourceproc" line 6)
    invoked from within
"ns_sourceproc cns95 {}"

Has anyone got this to work? It looks like the form variables are not getting passed to this page from the shopping cart.

Thanks. I thought the error was the "not in ()" part of this:

[17/Feb/2001:13:25:24][16947.968709][-conn26-] Error: dbinit: error(localhost::
nh,ERROR:  parser: parse error at or near ")"
): 'select max(item_id) from ec_items where product_id=1 and color_choice is nu
ll and size_choice is null and style_choice is null and order_id=27 and item_id
 not in ()'
[17/Feb/2001

I'll check the add to shopping cart routines to see if its inserting nulls or empty strings for non-existing attributes.

You can do that, but you're fixing the symptom rather than the problem.  The data-model was designed with the assumption that the empty fields would have nulls, so there might be other points in the code that fail due to the incorrect insertion of empty strings.  Fixing the insertion points would allow the data model to function as intended and it would probably be less work in the long run.  In any event I'll take a look at it later and see if I can track it down.

Excellent!  Thanks for tracking these down.  I would appreciate it if you could send me a diff when your done, so I can apply the changes to cvs.