Forum OpenACS Q&A: Project manager 1.05 released

I just committed project-manager, version 1.05.

Here are the changes:

Project manager

• Improves integration with logger (Added parameters for logger integration, added in admin UI pages for logger integration, add link to logger in navbar, add in proc to get logger url)
• Renamed the pm::task::dependency_options proc pm::task::options_list (I won't change public procs in the future, promise! Next time I'll deprecate them and so on..)
• Moved some code from add-edit pages to procs.
• Added ad_returnredirect messages after most form pages.
• Allow you to edit logger variables when editing projects.
• Took out most code from log.tcl, log.adp, etc pages (moved to logger)
• Added parameter to hide subprojects
• Improves appearance of admin pages.
• Added a dependency on kernel 5.1, and newer logger and organizations.
• Italicize the current location in the navbar
• Fixed the function in project-manager-functions-create that creates the root folder for project manager. Upgrade script included. This allows new installs to create projects!
• Added in pages that show the differences between versions of tasks and projects. Uses a word_diff to give you a nice looking difference between versions.
• Fixes issues described in posts the last couple of days, and a couple of other bugs as well.

Logger

• Added in ability to log against project-manager projects and tasks.
• Untabify: entries-postgresql.xql (sorry won't do it again!)
• Fixed scalability issue with one one function call per project being shown. Added in a dependency on new categories proc, which has a new proc that greatly speed up display of logger entries.
• Italicize the current location in the navbar
• Added in links to project-manager in the navbar, when project-manager is integrated with that instance of logger.
• optimized the variable::get_default_variable_id proc for postgres (much faster)
• sped up the select_users query by using persons instead of cc_users
• sped up entries select query by using persons instead of cc_users

Organizations

• Added a proc to return the name from an organization_id

Upgrade issues

Logger now requires a proc that is in cvs in 1.0d3, but if you already have categories 1.0d3, you may not have that proc. I can't bump categories to 1.0d4, because it's already there on HEAD, and it requires kernel 5.2.

If you notice this message when you view the project-manager or logger pages:

Error in include template "/var/lib/aolserver/intra-up/packages/logger/lib/entries": invalid command name "category_tree::get_mapped_trees_from_object_list"

then you're having this issue.

What do you need to do? You have to get the category_tree::get_mapped_trees_from_object_list proc from HEAD and copy it into your /packages/logger/lib/entries.tcl file.

Sorry for the inconvenience. I'm not sure how I could have done this differently. Perhaps I could have committed the code on the oacs-5-1 branch, and then tagged it openacs-5-1-compat, and then changed the file names in HEAD and version numbers too. Perhaps this is a lesson to me and others to leave gaps in your version numbers if you're not committing immediately?

Testing and code maturity

I've tested this install on HEAD, and on my local 5.1 install, and I'm using it in production, but I would appreciate any bug-reports, patches, etc.. Certainly there are bugs, although I think it's getting usable enough for production use.

The proc is to be found in this file:

http://cvs.openacs.org/cvs/openacs-4/packages/categories/tcl/category-trees-procs.tcl

and copied into logger as described by Jade above.

currently it does show up, but has a dependency on categories 0.3d which it claims cannot be found.

After making this change the logger is accessible.

If I link in a project and then set the parameter to integrate the logger instance with the project manager when I next browse to the logger page I get the error again as follows:

Error in include template "/web/tradeadev/packages/logger/lib/entries": invalid command name "category_tree::get_mapped_trees_from_object_list"

Any ideas?

Jade,

Sorry - that post was not very clear. I had read your instructions and posted the location of the proc after I found it to help others. However although following your instructions eliminated the error on initial browsing after mounting the package, as soon as I either create a new project in the logger or link a project that already exists in the project manager, I get the error again.

Just to double check, is this the correct proc to be putting into /lib/entries.tcl

ad_proc -public get_mapped_trees_from_object_list { object_id_list } {
    Get the category trees mapped to a list of objects.

    @param object_id_list list of object to get the mapped category trees.
    @return tcl list of lists: tree_id tree_name subtree_category_id
                assign_single_p require_category_p
    @author Jade Rubick (mailto:jader@bread.com)
} {
    set result [list]

    db_foreach get_mapped_trees_from_object_list "" {
        lappend result [list $tree_id [get_name $tree_id] $subtree_category_id $assign_single_p $require_category_p]
    }

    return $result
}

Regards
Richard

Hi Richard,

You need to put the following at the end of this file:

/packages/categories/tcl/category-trees-procs.tcl

----------------------

ad_proc -public get_mapped_trees_from_object_list { object_id_list } {
    Get the category trees mapped to a list of objects.

    @param object_id_list list of object to get the mapped category trees.
    @return tcl list of lists: tree_id tree_name subtree_category_id
                assign_single_p require_category_p
    @author Jade Rubick (mailto:jader@bread.com)
} {
    set result [list]

    db_foreach get_mapped_trees_from_object_list "" {
        lappend result [list $tree_id [get_name $tree_id] $subtree_category_id $assign_single_p $require_category_p]
    }

    return $result
}

---------------------------

and in /packages/categories/tcl/category-trees-procs.xql, below this section:

<fullquery name="category_tree::get_mapped_trees.get_mapped_trees">
      <querytext>

            select tree_id, subtree_category_id, assign_single_p,
                  require_category_p
            from category_tree_map
            where object_id = :object_id

      </querytext>
</fullquery>

----------------------
add this:
----------------------

<fullquery name="category_tree::get_mapped_trees_from_object_list.get_mapped_trees_from_object_list">
      <querytext>

            select tree_id, subtree_category_id, assign_single_p,
                  require_category_p
            from category_tree_map
            where object_id in ([join $object_id_list ", "])

      </querytext>
</fullquery>

---------------------

Hope that helps, and thank you for posting bug reports, and for providing all this feedback. Unfortunately, project-manager is a very complex piece of software, and I try to have it work perfectly, but it just doesn't cooperate!

Actually I had been eyeballing that query definition in the .xql file and wondering which version of the file needed which one, but the dotted notation of the the name threw me a bit.

I really need to learn plpgsql.

I have just tested the fix and it works.

I will keep testing and feeding back.

Regards
Richard

OK, have tied this down - please see bug report #1891

Jade,

I haven't put the test installation into CVS so I'll just post the modified entries.tcl on the bug tracker.

There may be some other variables tested with that syntax in the application but if so I have not yet seen an error because of them.

Regards
Richard