Forum OpenACS Q&A: Re: Tcl Callbacks

9: Re: Tcl Callbacks (response to 1)
Posted by Stan Kaufman on
Jeff, I'm happy to take this on since I'm one who was whingeing on about it so. What I intend to do is start with a fresh core install, and then sequentially add single packages (along with their dependencies obviously), create a bit of data, and try to uninstall the target package individually (ie not uninstalling any of the dependent packages). I'll file bugs on each package that won't uninstall along with whatever clues I can get re cause from the error log.

I have a several questions:

  • Since some of the uninstall problems may be with the apm, which version of core should I use -- HEAD? 5-1?

  • Which version of the target packages should I use? HEAD? 5-1-compat? (Despite Tip 61, I still am confused about where bug fixes are supposed to go, where they actually are going, and why. Bug-Tracker patches have been committed to HEAD but not 5-1-compat; Project-Manager patches have been committed to 5-1-compat. What is supposed to happen?)

  • Since the uninstall proc chain (beginning with apm_package_delete) includes stuff to remove site_nodes, I presume that to uninstall a package, the idea is simply to go to the Package Manager page and uninstall it without first unmounting and deleting the package instances from the Site Map. Is this correct? Or is uninstalling supposed to be a two-stage process where the user first removes the mounted packages via Site Map and then goes to the Package Manager? (If so, this should be documented somewhere -- like on the PM page "Warning -- remove all instances of the package from the Site Map first!!")
10: Re: Tcl Callbacks (response to 9)
Posted by Jeff Davis on
Just take a checkout via:
cvs co -r oacs-5-1 openacs-4
and submit bugs as found in "5.1".

I think you are a little confused on terminology: you can't commit on "5-1-compat" it's not a branch, the branches we currently are working with are oacs-5-1 and HEAD. openacs-5-1-compat is a "symbolic tag" and serves as an alias for the latest versions of a package which have been marked as compatible with the 5.1 release. You can only commit to a branch -- someone then needs to update the opeancs-5-1-compat symbolic tag to point at the latest version of that file on the branch on which the 5.1 compatible version of that file lives (for everything except project manager that symbolic tag should be pointed at the latest tested version on the oacs-5-1 branch).

In terms of testing uninstall, yes, I think the uninstall should work even if it's mounted so don't unmount things first -- just do the delete via the "Uninstall this package" at the bottom of the version view linked from the /acs-admin/apm/ page.