Forum .LRN Q&A: Re: .LRN 2.1 update

Collapse
4: Re: .LRN 2.1 update (response to 1)
Posted by Nima Mazloumi on 08/09/04 12:03 PM

Hi all,

here is the stuff I was working on last week:

Still Open

  • Orzenil/Dave and I were trying to fix a news aggregator problem. But we had no success. Since I was never able to verify this on the test server (for oracle) it would be great if someoen could try this out. The portlet should be broken and adding feeds too (diff see below). Also we found out that the queries a_add_source.add_source and na_add_source.add_item for news-aggregator-procs-oracle.xql have semi-colons after the "end" key word which Oracle doesn't like.
  • Photo-Album didn't work. I added the missing album-chunk-oracle.xql. Still I have an error adding a picture. Can someone verify this as well?
  • portrait upload fails (reported a bug: #2055)
  • community-member unable to include shared files temlate, page broken (reported a bug #2054)

Fixes/Improvements

  • While the weblogger-portlet package on CVS is accurate the one offered by the openacs repository contains an error in the sql: /packages/weblogger-portlet/www/weblogger-portlet-oracle.xql to_char(e.posted_date , 'HH24:MI') should be to_char(e.entry_date , 'HH24:MI') order by p.package_id asc, e.posted_date desc should be order by p.package_id asc, e.entry_date desc. This was fixed. Also a missing noquote in the webloger-portlet.adp (entries.content)
  • Missing noquote for the context-bar in dotlrn/www/community-member.adp added
  • Added unarchive for communities and classes. Works on Oracle and PostgreSQL (Thanks to Bergen).
  • Added links to forum admin portlet to see all forums and to admin the current forum (dotlrn-forums package)
  • Photo-Album - missing oracle queries for album-chunk added (thanks to Dave and Mark)
  • Added Translate Link to acs-developer-support header
  • Added Administration Cockpit for dotLRNs: User's controlpanel-->Cockpit link

Greetings,
Nima 

Index: news-aggregator/tcl/news-aggregator-procs-oracle.xql
===================================================================
RCS file: /cvsroot/openacs-4/packages/news-aggregator/tcl/Attic/news-aggregator-procs-oracle.xql,v
retrieving revision 1.2.4.1
diff -r1.2.4.1 news-aggregator-procs-oracle.xql
15,16c15,16
< 		 description => :description,
< 		 creation_user => :owner_id,
---
> 		         description => :description,
> 		         creation_user => :owner_id,
30,47c30,32
< 		 description => :description,
< 		 => sysdate,
< 		 => '0'
<              );
<              end
<         </querytext>
<     </fullquery>
< 
< <fullquery name="na_add_source.add_item">
<       <querytext>
< 	     begin
<              :1 := na_source.new (
<                  source_id => :source_id,
<             	 link => :link,
<              	 title => :title,
< 		 description => :description,
< 		 => sysdate,
< 		 => '0'
---
> 		         description => :description,
> 		         creation_date => sysdate,
> 		         deleted_p => '0'
Index: news-aggregator/tcl/news-aggregator-procs.tcl
===================================================================
RCS file: /cvsroot/openacs-4/packages/news-aggregator/tcl/news-aggregator-procs.tcl,v
retrieving revision 1.6
diff -r1.6 news-aggregator-procs.tcl
132a133,151
> ad_proc -public na_get_elements {
>      nodes
>      match
>  } {
>      set matches [list]
>      foreach node_id $nodes {
>          if { [string equal $match [xml_node_get_name $node_id]] } {
>              lappend matches $node_id
>          } else {
>              #set children [ns_xml node children $node_id]
>              set children [xml_node_get_children $node_id]
>              if { [llength $children] > 0 } {
>                  set matches [concat $matches [na_get_elements $children $match]]
>              }
>          }
>      }
>      return $matches
> }
> 
170,172c189,191
< 	    set title [string_truncate -len 245 -no_format -- [lindex $channel 0]]
< 	    set link [string_truncate -len 245 -no_format -- [lindex $channel 1]]
< 	    set description [string_truncate -len 245 -no_format -- [lindex $channel 2]]
---
> 	    set title [string_truncate -len 245 -- [lindex $channel 0]]
> 	    set link [string_truncate -len 245 -- [lindex $channel 1]]
> 	    set description [string_truncate -len 245 -- [lindex $channel 2]]
182,183c201,202
< 		    set title [string_truncate -len 245 -no_format -- [lindex $item 0]]
< 		    set link [string_truncate -len 245 -no_format -- [lindex $item 1]]
---
> 		    set title [string_truncate -len 245 -- [lindex $item 0]]
> 		    set link [string_truncate -len 245  -- [lindex $item 1]]
214,215c233,234
<             set title [string_truncate -len 245 -no_format -- [lindex $item 0]]
<             set link [string_truncate -len 245 -no_format -- [lindex $item 1]]
---
>             set title [string_truncate -len 245 -- [lindex $item 0]]
>             set link [string_truncate -len 245 -- [lindex $item 1]]
249,251c268,270
< 	    set title [string_truncate -len 245 -no_format -- [lindex $channel 0]]
< 	    set link [string_truncate -len 245 -no_format -- [lindex $channel 1]]
< 	    set description [string_truncate -len 245 -no_format -- [lindex $channel 2]]
---
> 	    set title [string_truncate -len 245 -- [lindex $channel 0]]
> 	    set link [string_truncate -len 245 -- [lindex $channel 1]]
> 	    set description [string_truncate -len 245 -- [lindex $channel 2]]