Forum OpenACS Q&A: Running tags

Collapse
1: Running tags
Posted by Andrei Popov on 05/07/01 10:49 AM
Just a thought: it is quite frequent that a [lousy/lazy] poster
forgets to terminate a tag ocassionally in an HTML post. It should be
fairly easy to parse a comment before inserting it into a database to
ensure that all tags are properly terminated... So, no patch/code
sniplet at this time.
Collapse
2: Response to Running tags (response to 1)
Posted by Cynthia Kiser on 05/09/01 11:11 PM
Collapse
3: Response to Running tags (response to 1)
Posted by Don Baccus on 05/10/01 12:44 AM
Smart-ass :)

The problem, Andrei, is that the current release of OpenACS 3.2.5 is
based on ACS Classic 3.2, which by all means of calculating age in the
web software world is ancient.  Old.  Over the hill.

You're more than welcome to investigate what it would take to backfit
the 3.2.5 forum scripts to use the proc mentioned by Cynthia.  There
will be a 3.2.6 release - we've got enough volunteer resources now to
make it possible to continue maintenance on OpenACS 3.2 while still
moving forward agressively on OpenACS 4.

If you decide to look into fixing this problem, just e-mail Roberto,
who will be coordinating the 3.2.6 release just as he did the 3.2.5
release.

(Roberto - in case people haven't noticed - ROCKS!)

Collapse
4: Response to Running tags (response to 1)
Posted by Roberto Mello on 05/10/01 01:11 AM
Thanks Don :)

Andrei, if you'd like to get that proc ported to OpenACS 3.2.x, just post it to SDM and I'll grab it from there, or e-mail me directly.

Collapse
5: Response to Running tags (response to 1)
Posted by Andrei Popov on 05/11/01 10:45 AM
I've posted a patch into SDM.  Please disregard patch #13: it is wrong.  #14 is a valid one.  Basically, it uses a wrapper from ACS 4.x distribution and corrects any open tags *before* even displaying a comment for confirmation.

This may be extended to also do text->html translation of Plain Text comments to (maybe) make posting of logs better (this seems to be a farily frequent thing as well: the while log being mashed into a single para).

Collapse
6: Response to Running tags (response to 1)
Posted by Andrei Popov on 05/11/01 04:49 PM
....ooops, quality checks did bot really pass.... can't figure why, but the fix works as long as util_close_html_tags is used, not ad_html_text_convert.

replacing this line:

set message [ ad_html_text_convert "html" "html" $message]

with this:

set message [ util_close_html_tags $message]

fixes it.  I'll see why it does not work otherwise, and then will resubmit the patch.