Forum OpenACS Q&A: new-file-storage FS_FILES versus FS_VERSIONS
1.) It starts with new-file-storage.sql:
insert into general_permission_types ( table_name, permission_type ) values ( 'FS_FILES', 'read' );file-storage.sql has FS_VERSIONS to insert into general_permission_types...
2.) When you do a "grep FS_FILES *" on /file-storage you get zero results. Sure they are all FS_VERSIONS
But on /new-file-storage you get results with FS_VERSIONS and FS_FILES on a grep.
Should you change all the FS_FILES into FS_VERSIONS or vice versa?
I haven't really bothered with general-permissions yet, but this looks weird...
versions makes no sense. Permissions scoped to files makes
sense. That's why the change was made.
LINE 80: and user_has_row_permission_p ($user_id, 'read', v.version_id, 'FS_VERSIONS') = 't'
has to be changed into
and user_has_row_permission_p ($user_id, 'read', f.file_id, 'FS_FILES') = 't'
I will commit that to SDM...
that being said, it does at complexity and opportunity for screwing up.
system is so far from usable that the activity you're talking about
seems significantly less likely than the idea of just sharing files
with a certain number of people. The interface isn't even set up to
hide versions you can't read (why would you need to see the
existence of old versions that you can't access?).
Anyhow, this is a rather moot point. File-storage was rather bad.
New-file-storage is a tad better. Unless someone is really
motivated to work on this 3.x version, I think we should focus on
making the 4.x version significantly better, starting with a better
idea of what this module is supposed to do.