Forum OpenACS Q&A: Upload attachemnts with comments broken?

Collapse
1: Upload attachemnts with comments broken?
Posted by Anton Bajri on 06/01/01 01:47 AM
The file /www/comments/upload-attachemnt.tcl has a "ns_ora
blob_dml_file ..." on line 92 that breaks the code. I use 3.2.4, but i
just looked at 3.2.5 in the CVS, and that ns_ora is there too. What i
do? I'm inclined to just commenting the functionality out, but can it
be saved?

Saludos,

Jorge

Collapse
2: Response to Upload attachemnts with comments broken? (response to 1)
Posted by Don Baccus on 06/01/01 02:02 PM
It shouldn't be hard to fix (it is a bug, indeed).  Grep for "ns_pg" and you'll find some blob examples in the source to copy, if you want to try to write a patch yourself.

Either way, report this in the SDM please, and if you build a patch submit it to the SDM, too.

Collapse
3: Response to Upload attachemnts with comments broken? (response to 1)
Posted by Anton Bajri on 06/01/01 03:48 PM
Ouch. I just looked in the SDM and that is there already. It references an older thread.
In the thread, the patch is reported as submitted in Feb. 19... by Don Baccus! :)

Saludos,

Jorge
Collapse
4: Response to Upload attachemnts with comments broken? (response to 1)
Posted by Ola Hansson on 06/02/01 12:14 PM
The changes committed by Mr. Baccus was done to /general-comments and not /comments.

Is /comments only old legacy cruft or is it being used?

Collapse
5: Response to Upload attachemnts with comments broken? (response to 1)
Posted by Anton Bajri on 06/03/01 07:20 AM
Uh oh. The /tcl/ad_html.tcl refers to www/comments all the time (in 3.2.5 also). I'm lost. The worst-scenario for me is ad_html is old/broken and i've been translating the wrong directory. :(
Anyway, i looked in the CVS and i see that ns_ora in both /comments and /general-comments.

Salduos,

Xopxe

Collapse
6: Response to Upload attachemnts with comments broken? (response to 1)
Posted by Anton Bajri on 06/06/01 05:06 PM
After leaving it in the back burner, looked at this again, and the thing is: /comments is for static htmls, and /general-comments is for database driven modules. I'll try the fix the ns_ora thing, someday :)

Saludos,

Jorge