Forum OpenACS Development: patch for template::adp_array_variable_regexp breaks using array variables in forms

Collapse
1: patch for template::adp_array_variable_regexp breaks using array variables in forms
Posted by Timo Hentschel on 01/13/05 10:32 AM
New 5.1 patch for template::adp_array_variable_regexp breaks using array variables in forms:

Adding "\." to template::adp_array_variable_regexp results in forms using array variables like "response.123" to break with "can't read formerror(choice.1): no such element in array".

Is this the expected and needed behaviour? If so, then why do we urgently need this patch? To have the current code working again right now, I rolled back that change for now.

Collapse
2: Re: patch for template::adp_array_variable_regexp breaks using array variables in forms (response to 1)
Posted by Dave Bauer on 01/13/05 03:57 PM
Timo,

Did you run the tests for acs-templating against this? There is a test to check that the regexp is working correctly.

I think your change is correct, but if you could confirm it by running the tests that would be great.

From my testing the regular array regexp and the noquote array regexp seemed to work differently, so that is why the noquote one needed the extra \. in it.