Forum OpenACS Q&A: Response to Nsvhr and nsunix for AOLserver 3.3ad13 available

Joshua Ginsberg reported a bug in nsvhr/nsunix: POSTs of binary data may fail with the first NULL. (I called Ns_DStringAppend instead of Ns_DStringNAppend)

Thank you Joshua!

The bug can be fixed with the patch I am including below.

If this patch gets munged in this post, you can find it at: http://www.theashergroup.com/bboard/q-and-a-fetch-msg.tcl?msg_id=00000G.

Index: nsvhr.c
===================================================================
RCS file: /cvs/ad33.13/aolserver/nsvhr/nsvhr.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -r1.2 -r1.3
37c37
< static const char *RCSID = "@(#) $Header: /cvs/ad33.13/aolserver/nsvhr/nsvhr.c,v 1.2 2001/08/30 05:33:44 jerry Exp $, compiled: " __DATE__ " " __TIME__;
---
> static const char *RCSID = "@(#) $Header: /cvs/ad33.13/aolserver/nsvhr/nsvhr.c,v 1.3 2001/09/19 10:57:03 jerry Exp $, compiled: " __DATE__ " " __TIME__;
1277c1277
<         // Ns_LogDumpString(Dev, buffer, numRead);
---
>         Ns_LogDumpString(Dev, buffer, numRead);
1279c1279
< 	Ns_DStringAppend(&request, buffer);
---
> 	Ns_DStringNAppend(&request, buffer, numRead);
1316c1316
<     Ns_Log(Dev, "nsvhr: sending to unix:%s on socket %d: %d [%s:%d] bytes.",
---
>     Ns_Log(Dev, "nsvhr: sending to unix:%s on socket %d: %d bytes. [%s:%d] ",