Forum OpenACS Development: CR bug on Windows - ns_mktemp

Collapse
1: CR bug on Windows - ns_mktemp
Posted by Ryan Gallimore on 06/03/09 01:19 PM
Hi,

I may have discovered a CR bug on Windows:

http://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl?r=1.24#l199

It looks like ns_mktemp will never be Windows compatible because /tmp is hard-coded.

ns_tmpnam appears to return the correct path on Windows and Linux.

Does anyone have other recommendations?

Regards

Collapse
2: Re: CR bug on Windows - ns_mktemp (response to 1)
Posted by Dave Bauer on 06/03/09 03:33 PM
I really have no idea of the difference between these two procedures. If it works I don't see any problem with changing it. There might be other places in the toolkit that also use ns_mktemp.
Collapse
3: Re: CR bug on Windows - ns_mktemp (response to 1)
Posted by Dave Bauer on 06/03/09 03:46 PM
Reading the link i see a much worse bug,

when the caller to content::revision::update_content has no temp filename passed in but the storage type is set to file, it creates a file from the text content so it can be stored correctly.

Since the caller is not aware of this temp file it can't remove it. Of course if you are using storage type "file" you should really pass in a file.

Collapse
4: Re: CR bug on Windows - ns_mktemp (response to 1)
Posted by Dave Bauer on 06/03/09 04:48 PM
Fixed both bugs and simplified the code to use existing cr_create_content_file_from_string procedure. This creates the string based file directly in the CR file area.

Fixed on oacs-5-5 will be merged to HEAD with everything else.

Thanks!

Collapse
5: Re: CR bug on Windows - ns_mktemp (response to 4)
Posted by Gustaf Neumann on 06/05/09 09:33 AM
Thanks Dave!