Like I said, my last work on GC is a bit old. The patch seems okay, but I don't have an anywhere near current OpenACS 4 install anymore (last update was in september IIRC) - so I can't really test it.
IIRC, the oracle stuff was done by the query-extractor with a cursory glance/test for correctness (just a test run, which did cover most of the normal code, but few of the special cases), there may even be FIXMEs for Oracle in there (probably not).
The most important things were the using the CR, which was never finished: URL attachments work, others don't (I may have started on that). There are one or two places (small) where the Oracle code is not in sync with the PG code. That is about all I can remember, and about all there was to it as well.
