Forum OpenACS Development: category::get_children sort by tree order

Collapse
1: category::get_children sort by tree order
Posted by Ryan Gallimore on 01/12/10 11:56 AM
category::get_children returns the children of a given category. However, it does no sorting.

I'd like to add an optional -order switch so it sorts by the tree order defined in category admin.

Any objections?

Collapse
2: Re: category::get_children sort by tree order (response to 1)
Posted by Dave Bauer on 01/12/10 01:56 PM
Ryan,

Can you check the existing calls to this procedure and see if the callers are already sorting the output? It might make sense to default to sorted output, I don't see much use for unsorted output.

Collapse
3: Re: category::get_children sort by tree order (response to 1)
Posted by Dave Bauer on 01/12/10 01:59 PM
Can you please also just fix it in general!?

It does a db_list then a foreach on the list to put the output into a list!

Then it checks for empty string on the output instead of llength 0.

I am also not sure why the result is "0" instead of just an empty list if there aren't any children. That seems weird.

Collapse
4: Re: category::get_children sort by tree order (response to 3)
Posted by Gustaf Neumann on 01/13/10 09:22 AM
the xo* packages do not use this function, the proposed changes won't break anything here. The suggestions of dave sound very reasonable.

-gustaf neumann

Collapse
5: Re: category::get_children sort by tree order (response to 3)
Posted by Ryan Gallimore on 01/13/10 11:25 AM
Dave, I'd be happy to clean up the proc while I'm at it. Thanks for the response, Gustaf.

Only planner and learning-content packages use category::get_children. In a few places, they do an lsort -increasing on the children ids. A sort of the children in the proc would only affect these existing calls (the children would be sorted twice).

Collapse
6: Re: category::get_children sort by tree order (response to 5)
Posted by Ryan Gallimore on 01/13/10 06:12 PM
I've committed to HEAD the changes to category::get_children. The proc is cleaner and returns a sorted list of categories.