Forum OpenACS Development: Re: upgrade acs-templating 5.1.5 to 5.5.1

Collapse
Posted by Gustaf Neumann on
The following change causes the problem since it assumes, that the parameter exists at the time the update script is executed (upgrade of acs-templating from 5.5.1d1 to 5.5.1d2)

http://fisheye.openacs.org/changelog/OpenACS?cs=oacs-5-5:victorg:20090724141231

The parameter was introduced in 5.2. Going straight from 5.1.* to 5.5.d2+ seems to cause the trouble, since apparently, the parameter would be created by the upgrade logic at some time after the callback.

2 ways to install:
a) upgrade first to some earlier version and then to 5.5.1
b) change acs-templating/tcl/apm-callback-procs.tcl to check, whether the parameter exists (easiest to check if $plugins after the parameter get is non-empty).

(b) should be done anyhow, but it would not help for people using the tar file.

Hope this helps
-gustaf neumann

Collapse
Posted by Victor Guerra on
Dear Iuri,

I just fixed upgrade script on branches oacs-5-5 and oacs-5-6 ( it will make it to HEAD as soon has all the fixes on the branch oacs-5-6 are merged to HEAD ).

Problem was that, as Gustaf mentioned before, the script was assuming the existence of this parameter.

So please, just do a cvs checkout from the oacs-5-5 branch.

Collapse
Posted by Iuri Sampaio on
Hi victor,

i did that already. I created the parameter manually by myself.
I was afraid there were more stuff to do aside creating the parameter.

Anyway, i read your scripts to check i i forgot anything plus to learn how your approach of things. Thank you so much!