Forum OpenACS Q&A: Re: ad_return_complaint causes errors to be logged

Collapse
Posted by Justis Peters on
P.S. This started happening after we upgraded to OpenACS 5.6, with code that didn't create these sorts of errors in previous versions.
Collapse
Posted by Brian Fenton on
Hi Justis

I'm afraid I can't be much help to you other than to confirm the problem on my installation too (but it's a much older version than 5.6).

Brian

Collapse
Posted by Jeff Rogers on
Looking at the definitions of template::adp_abort and template::adp_parse, in particular the error handling block of the latter, the intent seems to be that calling adp_abort will cause the current template being processed to return nothing without raising an error, while letting actual errors propagate up. However, the implementation of template::adp_abort doesn't return an appropriate error code to get into the correct branch of the switch.

On my own installation I changed template:adp_abort to call "return -code 10 ADP_ABORT" rather than "error ADP_ABORT" as it currently does, which makes it behave as it seems it should.