Forum OpenACS Development: Re: ns_ictl update error with tcllib tree library

Collapse
7: Re: ns_ictl update error with tcllib tree library (response to 1)
Posted by Gustaf Neumann on 05/11/12 02:06 PM
Can it be that you have upgraded not only openacs, but as well aolserver to the very latest version (4.5.2). There is a rather new commit introducing the renamings:

https://groups.google.com/forum/?fromgroups#!msg/aolserver-commits/XfhVZhUnYwo/HhB2hrCxqAgJ

The problem might already come from acs-tcl/tcl/util-diff-procs.tcl, which does a "package req struct::list"

I would recommend to give aolserver 4.5.1 a try

-gustaf

Collapse
9: Re: ns_ictl update error with tcllib tree library (response to 7)
Posted by Jeff Rogers on 05/11/12 07:29 PM
I've checked in a fix for this. It was a rather dumb oversight.

With this fix, packages like struct::list can be required in init scripts and used at runtime. Without it, the package would need to be required within the body of the proc in which they are used, which appears to be the case in util-diff-procs.tcl which predates this change.

Collapse
10: Re: ns_ictl update error with tcllib tree library (response to 9)
Posted by Gustaf Neumann on 05/12/12 11:37 AM
Thanks a lot!

If i see correctly, the fix is to remove the previously added rename attempt from the block handling the namespace imported commands. This mean probably that the renaming of namespace imported commands is not covered now. Would not a check for existence of the target of the name followed by a deletion of the command in case it exists help to cover this case?