Forum OpenACS Development: Re: Photo-Album Includelet for Xowiki

Collapse
35: Re: Photo-Album Includelet for Xowiki (response to 34)
Posted by Dave Bauer on 05/16/12 03:18 PM
OK, here is what I recommend.

Change the return style from image::convert_to_sizes to return something like this:

[list [list thumbnail {-strip -resize 150x150} view {-strip -resize 500x500]]

and fix the callers to intepret the new format. Since this is a private procedure and it is only called in two places, and only one place actually uses the dimensions part of the size specification.

Collapse
36: Re: Photo-Album Includelet for Xowiki (response to 35)
Posted by Richard Hamilton on 05/16/12 03:39 PM
Dave,

That sounds like a good suggestion. The only problem I foresee with that is that putting -strip in there will cause an error on earlier versions of ImageMagick.

It would also be useful to apply a change to the xowiki specific image resizing code.

Regards
Richard