Forum OpenACS Q&A: Re: Loading test procs even if parameter is disabled

Collapse
11: Re: Loading test procs even if parameter is disabled (response to 9)
Posted by Dave Bauer on 04/03/13 03:47 PM
So it looks like there is no code that ever sets load_tests but for some reason its still set as true by the tcl proc and the tests are loaded. This might affect memory usage of the Tcl interpreters slightly and is definitely a bad idea on production sites due to potential security issues and just a bad idea.
Collapse
14: Re: Loading test procs even if parameter is disabled (response to 11)
Posted by Dave Bauer on 04/03/13 04:32 PM
OK.

It was checking if acs-automated-testing package was enabled. I guess that is one way to do it, but the parameter enabled_p exists in acs-automated-testing so checking it seems a reasonable thing to do.

Collapse
17: Re: Loading test procs even if parameter is disabled (response to 11)
Posted by Brian Fenton on 04/04/13 10:04 AM
Hey Dave

great sleuthing there. When you're done, would mind listing all the changes you made? I've got a system or 2 that I'd love to see sped up.

thanks!
Brian