Forum OpenACS CMS: Re: XoWiki - Weird behaviour when editing form fields in numeric format

Played a little more with "\ " as separator: I don't think quoted values are a good idea into translations, as their effects become a bit unpredictable... lc_numeric function will format the number 10000 as "10\ 000", so we would have to check into the proc for quoted separators to fix it, opening to a fiddling hell of possible regressions.

If the " " value cannot be inserted into translations directly (without quoting), then the dot will be just fine as thousands separator.

Of course changing the separator will do, but what I found is that whenever the locale uses the same separator for decimals and thousands the issue will occur. It is not related to italian locale only.

I understand my fix touches very very stable code in responsible components of OpenAcs, but I think this problem deserves to be considered as a bug and solved (with priority and solution to your convenience). What is your opinion?

Came up with this, tell me what you think:

I put the check for the separators into a proc called lang::message::check, together with the check performed into lang::message::register to ensure a message contains all the variables required for substitution. This proc should contain all the semantic and sanity checks to be performed on messages now and in the future.

The new proc was then put into 3 places:

- lang::message::register in place of the former check
- a new regression test called lang_messages_correct, which performs the check on every message
- the on_submit block of the message key setting form, displaying an error on the form field when the check fails

If sounds reasonable to you I can send the patches

Patches sent!