Forum OpenACS Development: Re: Lars Blogger multilanguage support

Collapse
Posted by Richard Hamilton on

I have been reading through the content migration scripts for general interest and, please forgive me if I am mistaken, but I think something is amiss in the third example script posted here:

http://alice.wu-wien.ac.at:8000/xowiki-doc/#import-export-from-other-sources

8.3.2 Import and Export of XoWiki Pages from other Sources

...

if {$root(package_id) == $pinds(package_id)} {
  ns_return 200 text/plain "Cannot find xowiki instance '$xowiki_url'"
  ad_script_abort
} elseif {$root(package_id) == $pinds(package_id) } {
  ns_return 200 text/plain "Cannot find lars_blogger instance '$lars_blogger_url'"
  ad_script_abort
}

...

How can the elseif clause ever be true/executed?

It looks to me as if there might once have been an array set for the xowiki url #using [site_node::get_from_url -url $xowiki_url] # and that the if/elseif has been modified but not cleaned up.

This is clearly not important, but I think it might mean that if the lars blogger instance cannot be found, the error will say that it is the xowiki instance that cannot be found.

Collapse
Posted by Gustaf Neumann on
the code testing for the existence of an xowiki instance was not correct. i've updated it to make it look more reasonable.