Forum OpenACS Q&A: Possible bug in ACS Mail Lite

Hello,

since a while I have encountered a problem with a particular Mail provider when sending emails with attachments from an OpenAcs application. Attachments are not opened, and the recipient's mail clients complains about some safety reason for this.

I had no issues when sending directly from PC, so I have confronted the source of a sending from ACS Mail Lite and one from my client. I will skip to the relevant part:

- ACS Mail Lite
...
Content-Type: application/pdf;
name=""
...

- Thunderbird
...
Content-Type: application/pdf;
name="email_attachment_invoice-276628-1799717.pdf"
...

So there was no "name" assigned to the attachment. I have gone into packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl and, from line 426, I have tried to replace this part

db_foreach get_file_info {} {
lappend tokens [mime::initialize \
-param [list name "[ad_quotehtml $title]"] \
-header [list "Content-Disposition" "attachment; filename=\"$name\""] \
-header [list Content-Description $title] \
-canonical $mime_type \
-file "[cr_fs_path]$filename"]
}

with this

db_foreach get_file_info {} {
lappend tokens [mime::initialize \
-param [list name "[ad_quotehtml $title]"] \
-header [list "Content-Disposition" "attachment; filename=\"$name\""] \
-header [list Content-Description $title] \
-canonical "$mime_type; name=\"$name\"" \
-file "[cr_fs_path]$filename"]
}

Then I have sent again the email to my choosy provider. He was happy this time.

I have experienced this bug with every customer (around a dozen) using this particular provider (http://posta.libero.it). If it is ok I can commit the fix to the cvs.

Best regards.

Went deeper into the issue: 'name' parameter of content-type header is taken from 'title' column of cr_revisions. My application created attachments into content-repository with empty 'title' column, and so I had an empty name in content-type.

I have changed the code on my end so title is set and this should fix the problem without committing anything. Anyway, putting a one-liner to avoid empty names into content-type shouldn't hurt.

All this said, I really don't know what Libero provider is so worried about...