Forum OpenACS Development: Re: Towards OpenACS 5.9

Collapse
28: Re: Towards OpenACS 5.9 (response to 27)
Posted by Gustaf Neumann on
many of the admin functions are in a worse state than the end-user functions, there is probably much to do. Is there anyone willing and capable to improve this situation?
Collapse
29: Re: Towards OpenACS 5.9 (response to 28)
Posted by Antonio Pisano on
Properly pointed to problematic pages I could give a hand.
Collapse
30: Re: Towards OpenACS 5.9 (response to 29)
Posted by Benjamin Brink on
Hi Antonio,

I'd imagine an html validator could be used to crawl to detect major issues, such as nested TABLE at:

/acs-admin/apm/index

In general, much html should be as generic as possible to validate regardless of DTD and allow styling changes to be changed by css.

One could take this to an extreme by reducing block tags such as P and BLOCKQUOTE to DIV, and reducing in-line tags such as B and STRONG to SPAN with a reference to an existing (or new) site-master.css class equivalent. This approach at html reduction would eliminate needing re-write most html, because spans and divs can be nested.

Maybe it is practical to write a script to identify and make substitutions. Gustaf has made scripts to crawl openacs for tcl code standardization.

From an openacs packages dir, an awkwardly written grep shows circa 110+ TABLE tags that could have attributes removed, since they conflict with any css styles:

grep -R "<table" acs-* | grep -v resources | grep -v "www/doc/" | grep -v "www/xml/" | grep -v "<table>" | grep -v "acs-core-docs" | wc -l

thank you,
Benjamin

Collapse
31: Re: Towards OpenACS 5.9 (response to 30)
Posted by Benjamin Brink on
Hmm.. Replacing P with DIV might have some issues with simple substitution, because many P tags aren't closed.

Yet, there are apparently 2042 cases of P open tag and 1260 of P closed tag, using this awkward grep:

grep -R "</p" acs-* | grep -v resources | grep -v "www/doc/" | grep -v "www/xml/" | grep -v "acs-core-docs" | wc -l