Forum OpenACS Development: dotlrn dependencies in search package

1: dotlrn dependencies in search package

Posted by Nick Carroll on 05/21/06 03:21 PM

Why are there dotlrn dependencies in the search package? Who was responsible for putting these dependencies in the search package?

I have found a couple of dotlrn calls in search/www/search.tcl

2: Re: dotlrn dependencies in search package (response to 1)

Posted by Nick Carroll on 05/21/06 03:24 PM

These dependencies break the search package when it is installed on its own, or without dotlrn. Yes, some people like to use openacs without dotlrn installed.

3: Re: Re: dotlrn dependencies in search package (response to 2)

Posted by Dave Bauer on 05/21/06 03:28 PM

Hi nick,

Did you find this on HEAD? There shouldn't be any .LRN stuff on oacs-5-2.

That stuff needs to be extracted out because .LRN has some really different expectations on who can see what objects.

4: Re: dotlrn dependencies in search package (response to 1)

Posted by Nick Carroll on 05/22/06 03:10 AM

Hey Dave,

The dotlrn dependencies are in the HEAD version of the search package. They were added about 6 months ago. Can we just revert back to the previous file versions? Or are there things in the code that should be there for the version in HEAD?

Cheers,
Nick.

5: Re: Re: dotlrn dependencies in search package (response to 4)

Posted by Dave Bauer on 05/22/06 03:16 AM

Nick,

FOr now, I'd suggest using the fully tested serch package on oacs-5-2 branch. I'll be fixing the version in HEAD. HEAD means, in progress, broken, experimental. There are new features that should be very useful in the HEAD version that are being tested for a specific client right now. I'll try to spend a day fixing the HEAD version, I doubt it actually works on PostgreSQL at the moment without the dotlrn code.

6: Re: dotlrn dependencies in search package (response to 1)

Posted by Nick Carroll on 05/22/06 06:02 AM

OK. I think my problem is that I'm too lazy to add "-r oacs-5-2" to my cvs checkouts. :P Anyway I was having a good run with the code in HEAD.

I had a go at trying to fix the code in the search package, but there was obviously code there that I did not know what to do with. Perhaps a service contract needs to be created to check the permissions/priveleges on the object before displaying it? Other packages can then implement that service contract to hide certain objects.

Cheers,
Nick.

7: Re: dotlrn dependencies in search package (response to 1)

Posted by Dave Bauer on 05/22/06 12:43 PM

Nick,

You have the right general idea, but we will implement the optional features, ie: dotlrn integration, as callbacks, not service contracts. You can already see the support for callbacks in the other search operations.