Hi Stephen,
Thanks for the great feedback.
1. Tcl on Adp. I have placed a short example of that on my initial draft. Although it would be great if you can point me to where I can make my own ADP tags. I am not aware of anything in the doc that talks about this. I have just place my comment about this on the openacs.org docs section.
2. _p affix is something I forgot.... I will add it there. Maybe I should move return_url and _p to the "others" section. And maybe rename others as general.
3. Putting "SQL" seems to be more logical. I will add that too. I someone objects please do... otherwise no objection means acceptance.
4. p_ in plSQL is much better. I have used that several times. I think it makes it less confusing. For example you pass in item_id. Way down the code I am sure you will use item_id local var. So making item_id to p_item_id and v_item_id make it easier to know which is which. As far as tcl it don't seem to know why don't get a problem on it.... I don't know exactly why. Maybe its some odd norm.
Thanks for the feedback its great appreciated.