Forum OpenACS Q&A: Re: Re: Openacs process disappearing

Collapse
14: Re: Re: Openacs process disappearing (response to 11)
Posted by Jason Cheung on 06/28/06 04:56 AM
I have narrowed the problem to a problem in configuration or coding of my website. It seems the request processor is not handling server errors properly from invalid URLs.

72.30.61.43 - - [27/Jun/2006:02:07:50 +0800] "GET /robots.txt HTTP/1.1" 200 303
"" "Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/us/ysearch
/slurp)" -

[27/Jun/2006:02:07:51][25599.3024083888][-conn:service0::49] Notice: MONITORING WEBSITE MOVEMENT <<<<<
<<<<<<<<<< iso-8859-1 /public/contents/category?cid=1017%3C/p%3E%0D%0A%3Cp%3E >>>>>>>>>>>>>>>>>>>

What has been entered is a bad id being entered from the clients browser and it is not redirecting the 500 to a file-not-found.html in /global.

Furthermore, if the url as a space after the file name followed by the above query - it results in server error and process is gone.

Any advice is appreciated.

Collapse
15: Re: Re: Re: Openacs process disappearing (response to 14)
Posted by Jason Cheung on 06/28/06 05:06 AM
Whats odd is that /public/main is a valid url (there is a main.adp,tcl) and typing /public/maintestingerror redirects fine back to the home page - BUT if I try something like /public/contents/a then it crashes.
Collapse
16: Re: Re: Re: Re: Openacs process disappearing (response to 15)
Posted by Jason Cheung on 06/28/06 06:58 AM
It seems that the integer validation of cid is not working .. is there anything wrong with this snippet of code?

ad_page_contract {

A gateway, base one Category_id, redirect user to specific page

} {
cid:integer,notnull
{lang ""}
}

Collapse
17: Re: Re: Re: Re: Re: Openacs process disappearing (response to 16)
Posted by Gustaf Neumann on 06/28/06 10:25 AM
Jason, what version of openacs are you using? what version of tcl?

try the following in the shell:
set var x
set val 123
ad_page_contract_filter_proc_integer var val

(this is a valid test and returns 1) and then

set var x
set val [ns_urldecode 1017%3C/p%3E%0D%0A%3Cp%3E]
ad_page_contract_filter_proc_integer var val

(this is the test with the invalid id from your example)
If the integer test is the problem, the second one crashes.
the second call should return 0.

for me, this works nicely...

Collapse
18: Re: Re: Re: Re: Re: Re: Openacs process disappearing (response to 17)
Posted by Jason Cheung on 06/28/06 10:59 AM
Hi Gustaf,

Thank you for your reply,

openacs 5.1.2d
tcl: version 8.4

The two tests did not return any error - and to update on further investigation, another website (lets say website B) using the same tcl version and openacs version did not have the same problem with entering a string in the query. I.E. it would complain:

We had a problem with your input:

group_id is not an integer

Please back up using your browser, correct the above , and resubmit your entry.

Thank you.

Whereas in website A (if I enter category?cid=a),it returns 500 Internal Server Error. Tested string and email also; they work fine.

Not sure if it relates to the openacs core installation or the custom tcl code or aolserver configuration.

Collapse
19: Re: Re: Re: Re: Re: Re: Re: Openacs process disappearing (response to 18)
Posted by Gustaf Neumann on 06/28/06 11:25 AM
Jason, do the tests return on both systems the correct boolean value? To be sure, try to use the function ad_page_contract_filter integer from version 1.20 http://eye.openacs.org/viewrep/OpenACS/packages/acs-tcl/tcl/tcl-documentation-procs.tcl

don't you see any error message in the error log from the 500 error?

Collapse
20: Re: Re: Re: Re: Re: Re: Re: Re: Openacs process disappearing (response to 19)
Posted by Jason Cheung on 06/28/06 12:10 PM
Gustaf,

After some more testing it seems I know where the problem lies. It seems the master template (blank-master.adp) contained

ad_page_contract {

} {

{item_id:integer 0}
{cid:integer 0}
{return_url ""}

}
which it did not agree with .. guess it did do the validation after all and it was the display template which had the 500 problem!

Jason

Collapse
21: Re: Re: Re: Re: Re: Re: Re: Re: Re: Openacs process disappearing (response to 20)
Posted by Jason Cheung on 06/29/06 06:01 AM
I have 2 files - test.tcl and blank-master.tcl

test.tcl

ad_page_contract {

} {
x:notnull,integer
}

ns_log Notice INSIDETEST
ad_return_template

blank-master.tcl

ad_page_contract {

} {
{x ""}
}

ns_log Notice BLANKMASTER

How might I pass value of x into blank-master in usual circumstances such as test?x=1 and test?x=a (this works;returns error) and also catch invalid urls such as test?x=1017%3C/p%3E%0D%0A%3Cp%3E (this causes server error).

Collapse
22: Re: Re: Re: Re: Re: Re: Re: Re: Re: Re: Openacs process disappearing (response to 21)
Posted by Jason Cheung on 06/29/06 06:31 AM
A quick solution is to pass as a property in default-master and do integer validation further down in blank-master.

However, is there a coding convention that I am missing for passing queries to blank-master with better exception handling ?

The problem that I have had was rp processor displaying the error message within the master template which caught the same validation error thus resulting in a neverending error loop.