Forum OpenACS Development: Re: Re: Re: xoWiki and images

Posted by Orzenil Silva Junior on
Hi Deds,

Thank you for share. I followed up instructions you pointed and everything works well.

I think SG approach in this topic was very good providing several options to use xinha OacsFs plugin. We choose add XinhaFileStoragePackageID to forum package so we could now set the community/class file-storage package intance for store files/images and referring them inside forums. Great! A very attractive way to replace attachments package in forums.

Posted by Gustaf Neumann on
I am not to happy with this patch. do i see correctly, that it requires package ids to be specified as parameters? There must be better ways to do this. the resolver logic is way to complex for me and has hard coded names in it. There must be better ways for achieving this. The current implementation allows a per-form configuration of folders (not only package ids). The widget code should be able to derive the folder id from parameters and default values and pass it around. If the folder is specified via parameter, it should be specified via the URL such a user can do a cut&paste...
Posted by Deds Castillo on
Gustaf, this is just one way I scratched the itch and I'm not happy with it as well from a generic reusable kind of way that's why I mentioned I did it internally for SG and just have the code lying around if someone needs the same. :-)

I do admit it's not pretty at this point but we just needed something real quick that deviates from the default implementation. It just attempts to do more on the resolver but the code is backwards compatible with current implementation such that everything can still be passed by URL and folder ids are still supported. The package ids are not required to be specified as parameter but just an option that I check precedence-wise.

We also have several clients who use .lrn and .folio and we needed to support both with a single patch that's why the resolver looks complex. The only actual hard code on the resolver in the strict sense is the check on a mounted /xowiki which is already being mounted on install.

If you have implementations that achieve similar functionality lying around feel free to commit ;-) and we're sure to pull it. :-)