Forum OpenACS Development: Bug in template::paginator. My bad I think
some time ago I have touched template::list allowing to retrieve the full number of records extracted by pagination.
Now I think I have found a regression because of this. These are the steps to reproduce the problem on a current installation:
- open a xowiki instance an enter the admin page
- click on categories
- click on an existing category tree name or create one
- click on an existing category name or create one to open the page where usages of such category are shown
On my installation this leads to an error caused by "template::paginator::create" proc: since my change this proc requires 4 arguments instead of 3, bacause one should supply also the query to count the records. Script /packages/categories/www/cadmin/category-usage.tcl doesn't know about this an passes fourth argument "-pagesize" to the proc.
This happens also in script /packages/categories/www/categories-browse.tcl for the same reason (and maybe somewhere else?)
This scripts are particular, as they call template::paginator directly, rather than by calling template::list, and I have missed this use case...
Before I think about a fix (I may have found one), can you reproduce the issue, or am I missing some update?
This way public procs won't change anymore and the new feature will be transparent to existing code.
I'd prefer to commit the change after I receive confirmation of this bug, so I will wait for a couple of days
All the best
I had to use some tricks to avoid breaking any api... hope History won't judge me too much 😊
Due to cache behavior, I had to restart my instance after changes have been applied, otherwise my lists just came out empty. For you to know...
All the best