Forum OpenACS Development: Re: 'content_revision__del' not removing acs_permissions

Collapse
2: Re: 'content_revision__del' not removing acs_permissions (response to 1)
Posted by Gustaf Neumann on 04/18/16 03:12 PM
The manual deletion is not necessary since there is a "on delete cascade" on acs_permissions, introduced between 5.2.0d7 and 5.2.0d8. Can it be that ProjectOpen missed this? Or is there another problem?

-g
[1] https://github.com/openacs/openacs-core/commit/4a5c57b90423b37848e4bb22e4f83c0cfa33f925#diff-f738f95a230b32cc2af472d6612f37a5L137

Collapse
3: Re: 'content_revision__del' not removing acs_permissions (response to 2)
Posted by Klaus Hofeditz on 04/20/16 08:35 AM
Thanks Gustav,

the 'delete cascade' constraint of the acs_permissions table is indeed missing.
Among other techniques I used FishEye [1] to find the related update script for the change you referred me to, but I wasn't able to find it.

Cheers
Klaus

[1] http://cvs.openacs.org/search/OpenACS/?comment=&contents=&addedText=&deletedText=&filename=*upgrade-*&branch=oacs-5-9&tag=&fromdate=2005-02-25T00%3A00%3A00&todate=2005-03-01T00%3A00%3A00&datesortorder=DESCENDING&groupby=changeset&col=path&col=revision&col=author&col=date&col=csid&refresh=y

Collapse
4: Re: 'content_revision__del' not removing acs_permissions (response to 3)
Posted by Gustaf Neumann on 04/20/16 10:20 AM
At the time, the "on delete cascade" was added to acs_permissions, as it looks to me, don did not provide an upgrade script. There was as well a non-conforming naming of of the constraints "...on_what_id" vs. "...object_id", which was consolidated by [1] also for old installations.

-gn

[1] http://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-9%3Agustafn%3A20151231140020

Collapse
5: Re: 'content_revision__del' not removing acs_permissions (response to 4)
Posted by Klaus Hofeditz on 04/21/16 12:16 PM
Thanks so much for the clarification and for takin' the time looking into this.