Forum OpenACS Development: ad_set_form_values bug?

Collapse
1: ad_set_form_values bug?
Posted by Jun Yamog on 10/23/02 05:09 AM

Is this a bug on ad_set_form_values?

ad_set_form_values foo

if foo start with a "-" like "- bar". "- bar" is taken as a switch? 

Invalid switch: "- bar"
    while executing
"ad_set_element_value__arg_parser"
    (procedure "ad_set_element_value" line 1)
    invoked from within
"ad_set_element_value -element $arg $value"
    (procedure "ad_set_form_values" line 5)
Collapse
2: Response to ad_set_form_values bug? (response to 1)
Posted by Andrew Piskorski on 10/23/02 09:59 AM
Probably yes. It is a common mistake when using Tcl's switch statement. To fix, simply add "--" in the switch command, like so:
switch -exact -another_option -- $my_variable
Collapse
3: Response to ad_set_form_values bug? (response to 1)
Posted by Don Baccus on 10/23/02 06:04 PM
It's not a switch statement that's causing the problem, it's the switch (-ified parameters) parser ...

But the fix is similar ... ad_set_form_values calls ad_set_element_value and should have a "--" separating the arg that names the element and the value.  I'll fix this and commit to the 4.6 branch today.

Collapse
4: Response to ad_set_form_values bug? (response to 1)
Posted by Don Baccus on 10/24/02 01:12 AM
I've fixed this (haven't committed yet, will soon) but all that does is uncover a bug in the form templating system's "element::set" procedure.  The value always gets set to "1" if there's a leading "-".

And of course the templating system has its own arg parser ... grrr ... I'll look into fixing this one tomorrow.