Forum OpenACS Development: Re: Content Item New
there are several versions of content_item__new() around, which were introduced for backward compatibility. Some of these variants were deprecated more than 10 years ago.
If i count correctly, your code is calling content_item__new with 15 arguments. This is a non-deprecated variant. The problem you found is a typo in a variable, which sneaked in in early 2016 - in a code path, that is not often executed, otherwise it would have been detected earlier. I have fixed this bug in CVS in the HEAD branch and in oacs-5-9, such that people do not forced to the HEAD branch, when they are affected by this issue.
In general, calls to deprecated functions should work, but these should be replaced by non-deprecated variants.
all the best
I'm glad my debugging has contributed for a bug fix.