Forum OpenACS Development: Mail tracking totally broken on HEAD

Collapse
1: Mail tracking totally broken on HEAD
Posted by Dave Bauer on 12/20/06 09:02 PM
I installed mail-tracking today, and it is broken.

First there is to to_addr column in the acs_mail_log table, but the code tries to insert into that column.

Second acs_mail_log.log_id has a foreign key to acs_objects but no row in acs_objects is ever created.

Third lib/messages.tcl is full of calls to the contacts package.

Fourth, maybe, why is it dependent on file storage!?

Collapse
2: Re: Mail tracking WAS totally broken on HEAD (response to 1)
Posted by Malte Sussdorff on 12/21/06 08:19 AM
All issues have been resolved, thanks for noticing that I forgot to commit stuff.

As for the contacts dependencies, they are now handled through apm_package_installed_p

As for file-storage, good question... I removed it, the only reason I can think of is that it has a call in the callback procs, but this implementation is only called when File Storage is installed, so no need for this requirement.

Instead I added the requirement for acs-kernel 5.3

Collapse
3: Re: Mail tracking totally broken on HEAD (response to 1)
Posted by Dave Bauer on 12/21/06 01:54 PM
Thanks Malte, I'll check it out.