Forum OpenACS Development: To view file in /file-storage/view - ad_html_text_convertable_p

Request notifications

After upgrading to 5.10, /file-stroage/view/ returns error, calling ad_proc ad_html_text_convertable_p

Curiously, ad_html_text_convertable_p isn't in api-doc. However, it's implemented within acs-tcl/tcl/text-html-procs.tcl

No errors were returned, booting NS and loading acs-tcl/text-html-procs.tcl

Is the problem related to namespace?

Logs are bellow.

##
### 1. /file-storage/view/Screen_Shot_2019-03-15_at_14.53.45.png
##

[0;32m[15/Mar/2019:17:56:43][18056.7f1bd97fa700][-sched:25-] ^[[0m^[[0;39mNotice: nsdb: closing idle handle in pool 'pool1'^[[0m
^[[0;32m[15/Mar/2019:17:56:43][18056.7f1bd9ffb700][-sched:19-] ^[[0m^[[0;39mNotice: nsdbpg(postgres): Opened connection to localhost::dbname=iurix.^[[0m
^[[0;32m[15/Mar/2019:17:57:00][18056.7f1be9161700][-conn:iurix:1:407-] ^[[0m^[[1;31mError: rp_handler no-script-abort: errorMsg invalid command name "ad_html_text_convertable_p" while serving GET /file-storage/view/Screen_Shot_2019-03-15\
_at_13.37.56.png HTTP/1.0
ad_url /file-storage/view/Screen_Shot_2019-03-15_at_13.37.56.png maps to file /var/www/iurix/templates/file-storage-default.adp
TCL LOOKUP COMMAND ad_html_text_convertable_p
invalid command name "ad_html_text_convertable_p"
while executing
"ad_html_text_convertable_p -from $content(mime_type) -to text/html"
("uplevel" body line 7)
invoked from within
"uplevel {
# Put the current revision's attributes in a onerow datasource named "content".
# The detected content type is "content_revision".

cont..."
(procedure "code::tcl::/var/www/iurix//templates/file-storage-default" line 2)
invoked from within
"code::tcl::$__adp_stub"
("uplevel" body line 12)
invoked from within
"uplevel {

if { [file exists $__adp_stub.tcl] } {

# ensure that data source preparation procedure exists and is up-to-date
..."
(procedure "adp_prepare" line 2)
invoked from within
"adp_prepare"
invoked from within
"template::adp_parse $themed_template {}"
(procedure "adp_parse_ad_conn_file" line 14)
invoked from within

###
## 2. Booting NS and loading ad_procs
###

[[0;32m[15/Mar/2019:18:20:48][22079.7fee5b00b700][-main-] ^[[0m^[[0;39mNotice: Loaded packages/acs-tcl/tcl/test/test-set-cookie-procs.tcl.^[[0m
^[[0;32m[15/Mar/2019:18:20:48][22079.7fee5b00b700][-main-] ^[[0m^[[0;39mNotice: Loading packages/acs-tcl/tcl/test/text-html-procs.tcl...^[[0m
^[[0;32m[15/Mar/2019:18:20:48][22079.7fee5b00b700][-main-] ^[[0m^[[0;39mNotice: Loaded packages/acs-tcl/tcl/test/text-html-procs.tcl.^[[0m
^[[0;32m[15/Mar/2019:18:20:48][22079.7fee5b00b700][-main-] ^[[0m^[[0;39mNotice: Loading packages/acs-tcl/tcl/test/whos-online-procs.tcl...^[[0m
^[[0;32m[15/Mar/2019:18:20:48][22079.7fee5b00b700][-main-] ^[[0m^[[0;39mNotice: Loaded packages/acs-tcl/tcl/test/whos-online-procs.tcl.^[[0m
^

Dear Iuri,

this problem occurred in a file local to your site [1], that you use in file-storage/view. The old name "ad_html_text_convertable_p" contained a typo [2] and was replaced by "ad_html_text_convertible_p" in the (unreleased) oacs-5-10 branch. To improve backward compatibility, i've added the function with the old name and marked it as deprecated [3].

[1] /var/www/iurix//templates/file-storage-default
[2] https://english.stackexchange.com/questions/300821/why-convertible-and-not-convertable
[3] http://fisheye.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20190316180600