Forum OpenACS Development: acs_privilege_descendant_map created as a table

Collapse
1: acs_privilege_descendant_map created as a table
Posted by Keith Paskett on 09/28/22 06:47 AM
packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d20-5.10.0d21.sql drops the acs_privilege_descendant_map table and related functions/triggers. Then recreates it as a view based on a recursive query.

However...
packages/acs-kernel/sql/postgresql/acs-permissions-create.sql is still creating the table and related functions/triggers.

Also the column names are different between the table and the view--privilege,descendant vs parent,child.

The workaround it to manually run the upgrade-5.10.0d20-5.10.0d21.sql script after creating a new site.

I tried to submit this in the bug tracker, but got an error on submission.

Collapse
2: Re: acs_privilege_descendant_map created as a table (response to 1)
Posted by Gustaf Neumann on 09/28/22 10:30 AM
Dear Keith,

many thanks for the report. These are clearly two bugs.

The bug of the bug-tracker was introduced by marking a proc deprecated and immediately move these to tcl/deprecated-procs.tcl. When OpenACS is configured with WithDeprecatedCode set to 0 (which is the case on openacs.org), then this file is not loaded... which broke the bug-tracker package (which is not on the list of fully maintained packages).

The bug tracker is already fixes, sorry for the inconveniences. I will look at acs_privilege_descendant_map the next days.

all the best
-g
PS: i've also updated the coding guidelines to hint the drawback of eager moving procs the long-deprecated procs.

Collapse
3: Re: acs_privilege_descendant_map created as a table (response to 2)
Posted by Gustaf Neumann on 10/09/22 02:21 PM
The commit [1] has removes the obsolete tables/triggers/maintenance code from fresh installations. The change also contains an update script such that newer installations (still created with the obsolete tables) are corrected as well.

All the best, and thanks for noting.

[1] https://fisheye.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20221008200717