Forum OpenACS Development: Request: Pay attention to CVS log messages

1: Request: Pay attention to CVS log messages

Posted by Roberto Mello on 01/14/03 12:34 AM

Hi all,

Now that we are logging CVS message and making changelogs, I'd like to ask of CVS committers to pay attention to their log messages. Namely:

- Remember to capitalize first letters of phrases.
- Line breaks are good. CVS by default starts vi when you do
a cvs commit. Use it and break lines at 72 columns.
- Make sure your log messages are clear, to the point and concise.
- Use punctuation.

Thanks,

-Roberto

2: Re: Request: Pay attention to CVS log messages (response to 1)

Posted by Jeff Davis on 01/14/03 12:45 AM

Also, please reference bugs and patches where relevant
so we can generate links back to the bug reports
via something like "bug 137" or "patch 23".

3: Re: Request: Pay attention to CVS log messages (response to 1)

Posted by Roberto Mello on 01/14/03 01:08 AM

Oh yes, very good point Jeff.

In fact, while we are at it, we might as well start using what I plan to add to bug-tracker: automatic closing of bugs.

I will write a script that, through the cvs log, scans for certain things and automatically closes the bug. I plan to use the Debian bug tracking system's syntax (for consistency, and they already wrote the regexp's 😊).

So if you commit something and include something like: "(closes #1234567)" (or anything matched by the regxep /closes:\s*(?:bug)?\#\s*\d+(?:,\s*(?:bug)?\#\s*\d+)*/ig) where 1234567 is the bug id on bug-tracker, than that bug will be closed, and your commit log will be used as comments.

I believe that should take care of much of the problem of many bugs never being closed.

-Roberto