Forum OpenACS Development: Oracle issue with acs-tcl package 5.10.1 official

In upgrading an application to the latest 5.10.1 official release I've encountered an error where post site startup this error shows for any page:

invalid positional variable `:', valid values start with 1
    while executing
"ns_ora exec_plsql_bind $__DB [subst {BEGIN :1 := site_node.node_id(url => ::url$__optional_parameters); END;}] 1 {} "
    ("uplevel" body line 3)
    invoked from within
"uplevel 1 $code_block "
    invoked from within
"db_with_handle -dbn $dbn __DB {
  ns_log notice "Oracle: ns_ora exec_plsql_bind $__DB [subst {BEGIN :1 := site_node.node_id(url => ::url$__optional_pa..."
    (procedure "node_id" line 10)
    ::acs::dc ::acs::db::nsdb-oracle->call
    invoked from within
"next "

I've traced it to this file packages/acs-tcl/tcl/acs-db-12-procs.tcl and specifically with this line:

https://github.com/openacs/openacs-core/blob/a5d679965a7b440c74a4b20f51f1f4c3c1fc36ee/packages/acs-tcl/tcl/acs-db-12-procs.tcl#L658

The issue appears to be that of an extra ':' that is appended to the argument value that is returned from the `dbfunction_argument_value` call.

By making this simple one character change, the site springs back to life and all appears to be good.

658c658
 <                     lappend arguments  "$argument_name => :$argument_value"
 ---
 >                     lappend arguments  "$argument_name => $argument_value"

I am not sure if this is the correct fix or if this will cause other issues that I've not yet encountered.

Appreciate your review and response.

Hi Brian,

Thanks for the response but what I didn't include was the value of $argument_value is the result of this call:

set argument_value [:dbfunction_argument_value -name $argument_name -type $type]

In this `dbfunction_argument_value` it has this logic

if {[dict exists [:typemap] $type]} {
string cat CAST(: [string tolower $name] " AS " $type )
} else {
string cat : [string tolower $name]
}

So the result ends up being multiple `:` characters preceding the variable name which is the cause of the error.

Best,
Jon